Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping Python2 support #248

Merged
merged 9 commits into from
Oct 3, 2019
Merged

Dropping Python2 support #248

merged 9 commits into from
Oct 3, 2019

Conversation

carrascomj
Copy link
Member

I've removed six related code so Python2 shouldn't be supported anymore.

@phantomas1234 phantomas1234 self-requested a review October 3, 2019 13:28
Copy link
Collaborator

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2.7 should also be dropped from testing (.travis.yml).

@carrascomj
Copy link
Member Author

Ok, I am not very familiar with travis. It should be fine now.

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #248 into devel will decrease coverage by 0.49%.
The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##            devel     #248     +/-   ##
=========================================
- Coverage   62.85%   62.36%   -0.5%     
=========================================
  Files          56       56             
  Lines        5139     5109     -30     
  Branches      891      890      -1     
=========================================
- Hits         3230     3186     -44     
- Misses       1724     1738     +14     
  Partials      185      185
Impacted Files Coverage Δ
cameo/core/model_dual.py 5.63% <ø> (-1.32%) ⬇️
...euristic/evolutionary/multiprocess/optimization.py 31.25% <ø> (-0.61%) ⬇️
...eo/strain_design/heuristic/evolutionary/genomes.py 100% <ø> (ø) ⬆️
.../strain_design/heuristic/evolutionary/variators.py 93.38% <ø> (-0.06%) ⬇️
...ameo/strain_design/heuristic/evolutionary/stats.py 31.11% <ø> (-1.5%) ⬇️
...strain_design/heuristic/evolutionary/generators.py 93.75% <ø> (-0.37%) ⬇️
cameo/api/designer.py 68.61% <0%> (-1.39%) ⬇️
cameo/core/pathway.py 22.05% <0%> (-1.13%) ⬇️
cameo/core/utils.py 66.66% <0%> (-0.58%) ⬇️
cameo/api/hosts.py 93.18% <100%> (-0.16%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b09df...f05a9ae. Read the comment docs.

Copy link
Collaborator

@phantomas1234 phantomas1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks!

@phantomas1234 phantomas1234 merged commit 13571b9 into biosustain:devel Oct 3, 2019
phantomas1234 added a commit that referenced this pull request Nov 2, 2020
* Dropping Python2 support (#248)

* Dropping Python2 support

* Dropping Python 2 support, fixing typos

* Removed six from RTD requirements

* Typo parenthesis

* Fixing same typo on same line...

* Extracting first unique element of dictionary by list()

* Fixed typo

* Fixed wrong translation from iteritems

* Removed Python2 travis tests

* Chore upgrade all (#262)

* Dropping Python2 support

* Dropping Python 2 support, fixing typos

* Removed six from RTD requirements

* Typo parenthesis

* Fixing same typo on same line...

* Extracting first unique element of dictionary by list()

* Fixed typo

* Fixed wrong translation from iteritems

* Removed Python2 travis tests

* chore: update networkx

* chore: pin optlang for cobrapy 0.20

* chore: update pandas

* chore: downgrade networks lower requirement so that is py3.5 compatible

* docs: update package metadata

* Dropping Python2 support

* Dropping Python 2 support, fixing typos

* Extracting first unique element of dictionary by list()

* Fixed typo

* chore: update networkx

* chore: pin optlang for cobrapy 0.20

* chore: update pandas

* chore: downgrade networks lower requirement so that is py3.5 compatible

* docs: update package metadata

* style: apply flake8

* test: upgrade CI for 3.6,3.7,3.8

* docs: remove support for py35

* test: update travis dist to xenial

* test: remove six as dependency for tests

* fix: use the right tox envs

* test: force export TRAVIS to children processes

* test: pass travis variable through tox

* test: fix env variables tox

* fix: guard against divison by 0 (#263)

Co-authored-by: Jorge Carrasco <carrascomurielj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants