-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping Python2 support #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 2.7 should also be dropped from testing (.travis.yml
).
Ok, I am not very familiar with travis. It should be fine now. |
Codecov Report
@@ Coverage Diff @@
## devel #248 +/- ##
=========================================
- Coverage 62.85% 62.36% -0.5%
=========================================
Files 56 56
Lines 5139 5109 -30
Branches 891 890 -1
=========================================
- Hits 3230 3186 -44
- Misses 1724 1738 +14
Partials 185 185
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good, thanks!
* Dropping Python2 support (#248) * Dropping Python2 support * Dropping Python 2 support, fixing typos * Removed six from RTD requirements * Typo parenthesis * Fixing same typo on same line... * Extracting first unique element of dictionary by list() * Fixed typo * Fixed wrong translation from iteritems * Removed Python2 travis tests * Chore upgrade all (#262) * Dropping Python2 support * Dropping Python 2 support, fixing typos * Removed six from RTD requirements * Typo parenthesis * Fixing same typo on same line... * Extracting first unique element of dictionary by list() * Fixed typo * Fixed wrong translation from iteritems * Removed Python2 travis tests * chore: update networkx * chore: pin optlang for cobrapy 0.20 * chore: update pandas * chore: downgrade networks lower requirement so that is py3.5 compatible * docs: update package metadata * Dropping Python2 support * Dropping Python 2 support, fixing typos * Extracting first unique element of dictionary by list() * Fixed typo * chore: update networkx * chore: pin optlang for cobrapy 0.20 * chore: update pandas * chore: downgrade networks lower requirement so that is py3.5 compatible * docs: update package metadata * style: apply flake8 * test: upgrade CI for 3.6,3.7,3.8 * docs: remove support for py35 * test: update travis dist to xenial * test: remove six as dependency for tests * fix: use the right tox envs * test: force export TRAVIS to children processes * test: pass travis variable through tox * test: fix env variables tox * fix: guard against divison by 0 (#263) Co-authored-by: Jorge Carrasco <carrascomurielj@gmail.com>
I've removed six related code so Python2 shouldn't be supported anymore.