Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise error if a JSON dataset name conflicts #190

Closed
fedarko opened this issue Jul 15, 2019 · 0 comments
Closed

raise error if a JSON dataset name conflicts #190

fedarko opened this issue Jul 15, 2019 · 0 comments
Assignees
@fedarko
Labels
bug Something isn't working

Comments

@fedarko
Copy link
Collaborator

fedarko commented Jul 15, 2019

should never happen, but i suppose there might be a chance that the hashed dataset names that altair generate would conflict with one of our qurro_... dataset names in the rank or sample plot JSONs.

This should be fairly simple to check for.
@fedarko fedarko added the bug Something isn't working label Jul 15, 2019
@fedarko fedarko self-assigned this Jul 15, 2019
@fedarko fedarko closed this as completed in b270b37 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedarko fedarko

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fedarko