Skip to content

Commit c30c8f0

Browse files
committed
revised Protocol._make_index overload signatures
1 parent c6ed369 commit c30c8f0

File tree

20 files changed

+114
-103
lines changed

20 files changed

+114
-103
lines changed

pcapkit/protocols/application/httpv1.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def make(self, # type: ignore[override]
190190

191191
header_line = b'%s %s HTTP/%s\r\n' % (meth, uri_val, version)
192192
elif method is None and status is not None:
193-
status_code = self._make_index(status, status_default, namespace=status_namespace, # type: ignore[call-overload]
193+
status_code = self._make_index(status, status_default, namespace=status_namespace,
194194
reversed=status_reversed, pack=False)
195195
status_code_val = int(status_code)
196196

@@ -282,14 +282,14 @@ def _read_http_header(self, header: 'bytes') -> 'tuple[Data_Header, OrderedMulti
282282
match4 = re.match(_RE_STATUS, para2)
283283
if match1 and match2:
284284
header_line = Data_RequestHeader(
285-
type=Type.REQUEST,
285+
type=Type.REQUEST, # type: ignore[arg-type]
286286
method=Enum_Method.get(self.decode(para1)),
287287
uri=self.decode(para2),
288288
version=self.decode(match2.group('version')),
289289
)
290290
elif match3 and match4:
291291
header_line = Data_ResponseHeader(
292-
type=Type.RESPONSE,
292+
type=Type.RESPONSE, # type: ignore[arg-type]
293293
version=self.decode(match3.group('version')),
294294
status=Enum_StatusCode.get(int(para2)),
295295
message=self.decode(para3),

pcapkit/protocols/application/httpv2.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,8 +257,9 @@ def make(self, # type: ignore[override]
257257
Constructed packet data.
258258
259259
"""
260-
type_val = self._make_index(type, type_default, namespace=type_namespace, # type: ignore[call-overload]
261-
reversed=type_reversed, pack=False)
260+
type_val = cast('Enum_Frame',
261+
self._make_index(type, type_default, namespace=type_namespace,
262+
reversed=type_reversed, pack=False))
262263

263264
if isinstance(frame, bytes):
264265
length = len(frame) + 9
@@ -1035,7 +1036,7 @@ def _make_http_rst_stream(self, frame: 'Optional[Data_RSTStreamFrame]' = None, *
10351036
if frame is not None:
10361037
error_val = frame.error
10371038
else:
1038-
error_val = self._make_index(error, error_default, namespace=error_namespace, # type: ignore[call-overload]
1039+
error_val = self._make_index(error, error_default, namespace=error_namespace, # type: ignore[assignment]
10391040
reversed=error_reversed, pack=False)
10401041

10411042
return Schema_RSTStreamFrame(
@@ -1191,7 +1192,7 @@ def _make_http_goaway(self, frame: 'Optional[Data_GoawayFrame]' = None, *,
11911192
error_val = frame.error
11921193
debug = frame.debug_data
11931194
else:
1194-
error_val = self._make_index(error, error_default, namespace=error_namespace, # type: ignore[call-overload]
1195+
error_val = self._make_index(error, error_default, namespace=error_namespace, # type: ignore[assignment]
11951196
reversed=error_reversed, pack=False)
11961197

11971198
return Schema_GoawayFrame(

pcapkit/protocols/internet/ah.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,12 @@ def make(self,
179179
Constructed packet data.
180180
181181
"""
182-
next_value = self._make_index(next, next_default, namespace=next_namespace, # type: ignore[call-overload]
182+
next_value = self._make_index(next, next_default, namespace=next_namespace,
183183
reversed=next_reversed, pack=False)
184184
length = (len(icv) + 12) // 4 - 2
185185

186186
return Schema_AH(
187-
next=next_value,
187+
next=next_value, # type: ignore[arg-type]
188188
len=length,
189189
spi=spi,
190190
seq=seq,

pcapkit/protocols/internet/hip.py

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -537,9 +537,9 @@ def make(self,
537537
Constructed packet data.
538538
539539
"""
540-
next_value = self._make_index(next, next_default, namespace=next_namespace, # type: ignore[call-overload]
540+
next_value = self._make_index(next, next_default, namespace=next_namespace,
541541
reversed=next_reversed, pack=False)
542-
packet_value = self._make_index(packet, packet_default, namespace=packet_namespace, # type: ignore[call-overload]
542+
packet_value = self._make_index(packet, packet_default, namespace=packet_namespace,
543543
reversed=packet_reversed, pack=False)
544544

545545
if parameters is not None:
@@ -549,7 +549,7 @@ def make(self,
549549
parameters_value, length = [], 0
550550

551551
return Schema_HIP(
552-
next=next_value,
552+
next=next_value, # type: ignore[arg-type]
553553
len=length,
554554
pkt = {
555555
'bit_0': 0,
@@ -3204,7 +3204,7 @@ def _make_param_dh_group_list(self, code: 'Enum_Parameter', param: 'Optional[Dat
32043204

32053205
group_id = []
32063206
for group in groups:
3207-
group_id.append(self._make_index(group, group_default, namespace=group_namespace, # type: ignore[call-overload]
3207+
group_id.append(self._make_index(group, group_default, namespace=group_namespace, # type: ignore[arg-type]
32083208
reversed=group_reversed, pack=False))
32093209

32103210
return Schema_DHGroupListParameter(
@@ -3243,7 +3243,7 @@ def _make_param_diffie_hellman(self, code: 'Enum_Parameter', param: 'Optional[Da
32433243
pub_len = param.pub_len
32443244
pub_val = param.pub_val
32453245
else:
3246-
group_id = self._make_index(group, group_default, namespace=group_namespace, # type: ignore[call-overload]
3246+
group_id = self._make_index(group, group_default, namespace=group_namespace, # type: ignore[assignment]
32473247
reversed=group_reversed, pack=False)
32483248
pub_len = math.ceil(pub_val.bit_length() / 8)
32493249

@@ -3286,7 +3286,7 @@ def _make_param_hip_transform(self, code: 'Enum_Parameter', param: 'Optional[Dat
32863286

32873287
suite_id = []
32883288
for suite in suites:
3289-
suite_id.append(self._make_index(suite, suite_default, namespace=suite_namespace, # type: ignore[call-overload]
3289+
suite_id.append(self._make_index(suite, suite_default, namespace=suite_namespace, # type: ignore[arg-type]
32903290
reversed=suite_reversed, pack=False))
32913291

32923292
return Schema_HIPTransformParameter(
@@ -3326,7 +3326,7 @@ def _make_param_hip_cipher(self, code: 'Enum_Parameter', param: 'Optional[Data_H
33263326

33273327
cipher_id = []
33283328
for cipher in ciphers:
3329-
cipher_id.append(self._make_index(cipher, cipher_default, namespace=cipher_namespace, # type: ignore[call-overload]
3329+
cipher_id.append(self._make_index(cipher, cipher_default, namespace=cipher_namespace, # type: ignore[arg-type]
33303330
reversed=cipher_reversed, pack=False))
33313331

33323332
return Schema_HIPCipherParameter(
@@ -3366,7 +3366,7 @@ def _make_param_nat_traversal_mode(self, code: 'Enum_Parameter', param: 'Optiona
33663366

33673367
mode_id = []
33683368
for mode in modes:
3369-
mode_id.append(self._make_index(mode, mode_default, namespace=mode_namespace, # type: ignore[call-overload]
3369+
mode_id.append(self._make_index(mode, mode_default, namespace=mode_namespace, # type: ignore[arg-type]
33703370
reversed=mode_reversed, pack=False))
33713371

33723372
return Schema_NATTraversalModeParameter(
@@ -3432,7 +3432,7 @@ def _make_param_encrypted(self, code: 'Enum_Parameter', param: 'Optional[Data_En
34323432
iv = param.iv
34333433
data = param.data
34343434
else:
3435-
cipher_id = self._make_index(cipher, cipher_default, namespace=cipher_namespace, # type: ignore[call-overload]
3435+
cipher_id = self._make_index(cipher, cipher_default, namespace=cipher_namespace, # type: ignore[assignment]
34363436
reversed=cipher_reversed, pack=False)
34373437

34383438
if cipher_id in (Enum_Cipher.AES_128_CBC, Enum_Cipher.AES_256_CBC):
@@ -3497,9 +3497,9 @@ def _make_param_host_id(self, code: 'Enum_Parameter', param: 'Optional[Data_Host
34973497
algorithm = param.algorithm # type: int | Enum_HIAlgorithm
34983498
else:
34993499
di_len = len(di)
3500-
di_enum = self._make_index(di_type, di_type_default, namespace=di_type_namespace, # type: ignore[call-overload]
3500+
di_enum = self._make_index(di_type, di_type_default, namespace=di_type_namespace, # type: ignore[assignment]
35013501
reversed=di_type_reversed, pack=False)
3502-
algorithm = self._make_index(hi_algorithm, hi_algorithm_default, namespace=hi_algorithm_namespace, # type: ignore[call-overload]
3502+
algorithm = self._make_index(hi_algorithm, hi_algorithm_default, namespace=hi_algorithm_namespace,
35033503
reversed=hi_algorithm_reversed, pack=False)
35043504

35053505
if hi is None:
@@ -3598,7 +3598,7 @@ def _make_param_hit_suite_list(self, code: 'Enum_Parameter', param: 'Optional[Da
35983598

35993599
suite_id = []
36003600
for suite in suites:
3601-
suite_id.append(self._make_index(suite, suite_default, namespace=suite_namespace, # type: ignore[call-overload]
3601+
suite_id.append(self._make_index(suite, suite_default, namespace=suite_namespace, # type: ignore[arg-type]
36023602
reversed=suite_reversed, pack=False))
36033603

36043604
return Schema_HITSuiteListParameter(
@@ -3651,11 +3651,11 @@ def _make_param_cert(self, code: 'Enum_Parameter', param: 'Optional[Data_CertPar
36513651
type = param.cert_type
36523652
cert = param.cert
36533653
else:
3654-
group = self._make_index(cert_group, cert_group_default, namespace=cert_group_namespace, # type: ignore[call-overload]
3654+
group = self._make_index(cert_group, cert_group_default, namespace=cert_group_namespace, # type: ignore[assignment]
36553655
reversed=cert_group_reversed, pack=False)
36563656
count = cert_count
36573657
id = cert_id
3658-
type = self._make_index(cert_type, cert_type_default, namespace=cert_type_namespace, # type: ignore[call-overload]
3658+
type = self._make_index(cert_type, cert_type_default, namespace=cert_type_namespace, # type: ignore[assignment]
36593659
reversed=cert_type_reversed, pack=False)
36603660

36613661
return Schema_CertParameter(
@@ -3697,7 +3697,7 @@ def _make_param_notification(self, code: 'Enum_Parameter', param: 'Optional[Data
36973697
type = param.msg_type
36983698
msg = param.msg
36993699
else:
3700-
type = self._make_index(msg_type, msg_type_default, namespace=msg_type_namespace, # type: ignore[call-overload]
3700+
type = self._make_index(msg_type, msg_type_default, namespace=msg_type_namespace, # type: ignore[assignment]
37013701
reversed=msg_type_reversed, pack=False)
37023702

37033703
return Schema_NotificationParameter(
@@ -3770,7 +3770,7 @@ def _make_param_reg_info(self, code: 'Enum_Parameter', param: 'Optional[Data_Reg
37703770

37713771
reg_type = []
37723772
for reg in reg_info:
3773-
reg_type.append(self._make_index(reg, reg_info_default, namespace=reg_info_namespace, # type: ignore[call-overload]
3773+
reg_type.append(self._make_index(reg, reg_info_default, namespace=reg_info_namespace, # type: ignore[arg-type]
37743774
reversed=reg_info_reversed, pack=False))
37753775

37763776
min_lt = min_lifetime if isinstance(min_lifetime, int) else math.floor(min_lifetime.total_seconds())
@@ -3818,7 +3818,7 @@ def _make_param_reg_request(self, code: 'Enum_Parameter', param: 'Optional[Data_
38183818

38193819
reg_type = []
38203820
for reg in reg_request:
3821-
reg_type.append(self._make_index(reg, reg_request_default, namespace=reg_request_namespace, # type: ignore[call-overload]
3821+
reg_type.append(self._make_index(reg, reg_request_default, namespace=reg_request_namespace, # type: ignore[arg-type]
38223822
reversed=reg_request_reversed, pack=False))
38233823

38243824
lt = lifetime if isinstance(lifetime, int) else math.floor(lifetime.total_seconds())
@@ -3858,7 +3858,7 @@ def _make_param_reg_response(self, code: 'Enum_Parameter', param: 'Optional[Data
38583858

38593859
reg_type = []
38603860
for reg in reg_response:
3861-
reg_type.append(self._make_index(reg, reg_response_default, namespace=reg_response_namespace, # type: ignore[call-overload]
3861+
reg_type.append(self._make_index(reg, reg_response_default, namespace=reg_response_namespace, # type: ignore[arg-type]
38623862
reversed=reg_response_reversed, pack=False))
38633863

38643864
lt = lifetime if isinstance(lifetime, int) else math.floor(lifetime.total_seconds())
@@ -3903,7 +3903,7 @@ def _make_param_reg_failed(self, code: 'Enum_Parameter', param: 'Optional[Data_R
39033903

39043904
reg_type = []
39053905
for reg in reg_failed:
3906-
reg_type.append(self._make_index(reg, reg_failed_default, namespace=reg_failed_namespace, # type: ignore[call-overload]
3906+
reg_type.append(self._make_index(reg, reg_failed_default, namespace=reg_failed_namespace, # type: ignore[arg-type]
39073907
reversed=reg_failed_reversed, pack=False))
39083908

39093909
lt = lifetime if isinstance(lifetime, int) else math.floor(lifetime.total_seconds())
@@ -3947,7 +3947,7 @@ def _make_param_reg_from(self, code: 'Enum_Parameter', param: 'Optional[Data_Reg
39473947
proto = param.protocol
39483948
address = param.address
39493949
else:
3950-
proto = self._make_index(protocol, protocol_default, namespace=protocol_namespace, # type: ignore[call-overload]
3950+
proto = self._make_index(protocol, protocol_default, namespace=protocol_namespace, # type: ignore[assignment]
39513951
reversed=protocol_reversed, pack=False)
39523952

39533953
return Schema_RegFromParameter(
@@ -4015,7 +4015,7 @@ def _make_param_transport_format_list(self, code: 'Enum_Parameter', param: 'Opti
40154015

40164016
tf_type = []
40174017
for tf in formats:
4018-
tf_type.append(self._make_index(tf, format_default, namespace=format_namespace, # type: ignore[call-overload]
4018+
tf_type.append(self._make_index(tf, format_default, namespace=format_namespace, # type: ignore[arg-type]
40194019
reversed=format_reversed, pack=False))
40204020

40214021
return Schema_TransportFormatListParameter(
@@ -4055,7 +4055,7 @@ def _make_param_esp_transform(self, code: 'Enum_Parameter', param: 'Optional[Dat
40554055

40564056
suite_id = []
40574057
for suite in suites:
4058-
suite_id.append(self._make_index(suite, suite_default, namespace=suite_namespace, # type: ignore[call-overload]
4058+
suite_id.append(self._make_index(suite, suite_default, namespace=suite_namespace, # type: ignore[arg-type]
40594059
reversed=suite_reversed, pack=False))
40604060

40614061
return Schema_ESPTransformParameter(
@@ -4149,7 +4149,7 @@ def _make_param_payload_mic(self, code: 'Enum_Parameter', param: 'Optional[Data_
41494149
payload = param.payload
41504150
mic = param.mic
41514151
else:
4152-
protocol = self._make_index(next, next_default, namespace=next_namespace, # type: ignore[call-overload]
4152+
protocol = self._make_index(next, next_default, namespace=next_namespace, # type: ignore[assignment]
41534153
reversed=next_reversed, pack=False)
41544154

41554155
return Schema_PayloadMICParameter(
@@ -4280,7 +4280,7 @@ def _make_param_hip_transport_mode(self, code: 'Enum_Parameter', param: 'Optiona
42804280

42814281
mode_id = []
42824282
for mode in modes:
4283-
mode_id.append(self._make_index(mode, mode_default, namespace=mode_namespace, # type: ignore[call-overload]
4283+
mode_id.append(self._make_index(mode, mode_default, namespace=mode_namespace, # type: ignore[arg-type]
42844284
reversed=mode_reversed, pack=False))
42854285

42864286
return Schema_HIPTransportModeParameter(
@@ -4371,7 +4371,7 @@ def _make_param_hip_signature_2(self, code: 'Enum_Parameter', param: 'Optional[D
43714371
algo = param.algorithm
43724372
signature = param.signature
43734373
else:
4374-
algo = self._make_index(algorithm, algorithm_default, namespace=algorithm_namespace, # type: ignore[call-overload]
4374+
algo = self._make_index(algorithm, algorithm_default, namespace=algorithm_namespace, # type: ignore[assignment]
43754375
reversed=algorithm_reversed, pack=False)
43764376

43774377
return Schema_HIPSignature2Parameter(
@@ -4410,7 +4410,7 @@ def _make_param_hip_signature(self, code: 'Enum_Parameter', param: 'Optional[Dat
44104410
algo = param.algorithm
44114411
signature = param.signature
44124412
else:
4413-
algo = self._make_index(algorithm, algorithm_default, namespace=algorithm_namespace, # type: ignore[call-overload]
4413+
algo = self._make_index(algorithm, algorithm_default, namespace=algorithm_namespace, # type: ignore[assignment]
44144414
reversed=algorithm_reversed, pack=False)
44154415

44164416
return Schema_HIPSignatureParameter(
@@ -4501,7 +4501,7 @@ def _make_param_relay_from(self, code: 'Enum_Parameter', param: 'Optional[Data_R
45014501
proto = param.protocol
45024502
address = param.address
45034503
else:
4504-
proto = self._make_index(protocol, protocol_default, namespace=protocol_namespace, # type: ignore[call-overload]
4504+
proto = self._make_index(protocol, protocol_default, namespace=protocol_namespace, # type: ignore[assignment]
45054505
reversed=protocol_reversed, pack=False)
45064506

45074507
return Schema_RelayFromParameter(
@@ -4544,7 +4544,7 @@ def _make_param_relay_to(self, code: 'Enum_Parameter', param: 'Optional[Data_Rel
45444544
proto = param.protocol
45454545
address = param.address
45464546
else:
4547-
proto = self._make_index(protocol, protocol_default, namespace=protocol_namespace, # type: ignore[call-overload]
4547+
proto = self._make_index(protocol, protocol_default, namespace=protocol_namespace, # type: ignore[assignment]
45484548
reversed=protocol_reversed, pack=False)
45494549

45504550
return Schema_RelayToParameter(

0 commit comments

Comments
 (0)