Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JS to Get it Out of Views #820

Open
marrero984 opened this issue Aug 17, 2017 · 1 comment
Open

Refactor JS to Get it Out of Views #820

marrero984 opened this issue Aug 17, 2017 · 1 comment

Comments

@marrero984
Copy link
Contributor

Some of the JS has ended up in the view files. We should refactor it so that the code is separate from the view. This can either be done by finding a way to better identify which view the user is in, or by creating a third JS file, audience.js, for that logic that only applies to the audience view.

@binford2k
Copy link
Owner

The code that's in the views is (should be) in there because it has to be programmatically generated. Like keymap = <%= JSON.pretty_generate @keymap %>;, for example. This part cannot be removed.

There's quite a bit though that can/should be refactored out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants