Use view finder from parent class

Author: kevinsawicki

app/src/main/java/com/github/mobile/ui/DialogFragment.java

@@ -17,7 +17,9 @@
 
 import android.app.Activity;
 import android.os.Bundle;
+import android.view.View;
 
+import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.rtyley.android.sherlock.roboguice.fragment.RoboSherlockFragment;
 
 import java.io.Serializable;
@@ -28,6 +30,12 @@
 public abstract class DialogFragment extends RoboSherlockFragment implements
         DialogResultListener {
 
+    /**
+     * View finder bound to the value last specified to
+     * {@link #onViewCreated(android.view.View, Bundle)}
+     */
+    protected ViewFinder finder;
+
     /**
      * Is this fragment usable from the UI-thread
      *
@@ -70,4 +78,11 @@ protected String getStringExtra(final String name) {
         else
             return null;
     }
+
+    @Override
+    public void onViewCreated(View view, Bundle savedInstanceState) {
+        super.onViewCreated(view, savedInstanceState);
+
+        finder = new ViewFinder(view);
+    }
 }

app/src/main/java/com/github/mobile/ui/code/RepositoryCodeFragment.java

@@ -34,7 +34,6 @@
 import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuInflater;
 import com.actionbarsherlock.view.MenuItem;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.kevinsawicki.wishlist.ViewUtils;
 import com.github.mobile.R.color;
 import com.github.mobile.R.id;
@@ -217,7 +216,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         progressView = finder.find(id.pb_loading);
         listView = finder.find(android.R.id.list);
         listView.setOnItemClickListener(this);

app/src/main/java/com/github/mobile/ui/comment/RawCommentFragment.java

@@ -23,24 +23,22 @@
 import android.widget.EditText;
 
 import com.actionbarsherlock.app.SherlockFragmentActivity;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.mobile.R.id;
 import com.github.mobile.R.layout;
+import com.github.mobile.ui.DialogFragment;
 import com.github.mobile.ui.TextWatcherAdapter;
-import com.github.rtyley.android.sherlock.roboguice.fragment.RoboSherlockFragment;
 
 /**
  * Fragment to display raw comment text
  */
-public class RawCommentFragment extends RoboSherlockFragment {
+public class RawCommentFragment extends DialogFragment {
 
     private EditText commentText;
 
     @Override
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         commentText = finder.find(id.et_comment);
         commentText.addTextChangedListener(new TextWatcherAdapter() {
 

app/src/main/java/com/github/mobile/ui/commit/CommitCompareListFragment.java

@@ -34,7 +34,6 @@
 import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuInflater;
 import com.actionbarsherlock.view.MenuItem;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.kevinsawicki.wishlist.ViewUtils;
 import com.github.mobile.R.id;
 import com.github.mobile.R.layout;
@@ -208,7 +207,6 @@ private void addFileStatHeader(List<CommitFile> files,
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         list = finder.find(android.R.id.list);
         progress = finder.find(id.pb_loading);
 

app/src/main/java/com/github/mobile/ui/commit/CommitDiffListFragment.java

@@ -42,7 +42,6 @@
 import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuInflater;
 import com.actionbarsherlock.view.MenuItem;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.kevinsawicki.wishlist.ViewUtils;
 import com.github.mobile.R.id;
 import com.github.mobile.R.layout;
@@ -361,7 +360,6 @@ private void updateItems(List<CommitComment> comments,
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         list = finder.find(android.R.id.list);
         progress = finder.find(id.pb_loading);
 

app/src/main/java/com/github/mobile/ui/commit/CommitListFragment.java

@@ -32,7 +32,6 @@
 import android.widget.TextView;
 
 import com.github.kevinsawicki.wishlist.SingleTypeAdapter;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.kevinsawicki.wishlist.ViewUtils;
 import com.github.mobile.R.id;
 import com.github.mobile.R.layout;
@@ -263,7 +262,6 @@ public ItemListFragment<RepositoryCommit> setListShown(boolean shown,
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         branchFooterView = finder.find(id.rl_branch);
         branchView = finder.find(id.tv_branch);
         branchIconView = finder.find(id.tv_branch_icon);

app/src/main/java/com/github/mobile/ui/gist/GistFileFragment.java

@@ -31,7 +31,6 @@
 import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuInflater;
 import com.actionbarsherlock.view.MenuItem;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.mobile.R.id;
 import com.github.mobile.R.layout;
 import com.github.mobile.R.menu;
@@ -191,7 +190,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         webView = finder.find(id.wv_code);
 
         editor = new SourceEditor(webView);

app/src/main/java/com/github/mobile/ui/gist/GistFragment.java

@@ -38,7 +38,6 @@
 import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuInflater;
 import com.actionbarsherlock.view.MenuItem;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.kevinsawicki.wishlist.ViewUtils;
 import com.github.mobile.R.id;
 import com.github.mobile.R.layout;
@@ -145,7 +144,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         list = finder.find(android.R.id.list);
         progress = finder.find(id.pb_loading);
 

app/src/main/java/com/github/mobile/ui/issue/IssueFragment.java

@@ -50,7 +50,6 @@
 import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuInflater;
 import com.actionbarsherlock.view.MenuItem;
-import com.github.kevinsawicki.wishlist.ViewFinder;
 import com.github.kevinsawicki.wishlist.ViewUtils;
 import com.github.mobile.R.drawable;
 import com.github.mobile.R.id;
@@ -252,7 +251,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
     public void onViewCreated(View view, Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
 
-        ViewFinder finder = new ViewFinder(view);
         list = finder.find(android.R.id.list);
         progress = finder.find(id.pb_loading);