This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. #6657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/binary-static/9k2DBvHq6C2JsNB8p6NotbkKfuwV |
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
akmal-deriv
previously approved these changes
Jul 7, 2021
added 2 commits
July 12, 2021 14:33
ali-fs
added a commit
to ali-fs/binary-static
that referenced
this pull request
Jul 15, 2021
* add automatic translation action (binary-com#6649) * Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637) * added a survey for English, Spanish and Portuguese * added the survey code snippet * --- * update english survey snippet * translations: 📚 sync translations with crowdin (binary-com#6652) * Prince/ Incorrect error message payment agent transfer (binary-com#6627) * Chore: added validation condition under numbers * Chore: Lint Fix * Chore: Applied form validation on payment agent transfer form * translations: 📚 sync translations with crowdin (binary-com#6656) * Amina/invalid_characters_on_barriers_mobile (binary-com#6645) * input type changed * test * linting fix * removed PA availability notice (binary-com#6639) * percentage_updated (binary-com#6642) * translations: 📚 sync translations with crowdin (binary-com#6658) * translations: 📚 sync translations with crowdin (binary-com#6659) * Akmal / Add responsiveness to last digit stats title (binary-com#6636) * Add responsiveness to last digit stats title * Remove extra padding * Akmal / Disable purchase button when there is no trading (binary-com#6638) * Disable purchase button when there is no trading * Add more spaces * Add client logged in check * translations: 📚 sync translations with crowdin (binary-com#6660) * Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662) This reverts commit 022998e. * translations: 📚 sync translations with crowdin (binary-com#6663) * translations: 📚 sync translations with crowdin (binary-com#6664) * Kevin/Account closure peding withdrawal(s) error message (binary-com#6620) * account closure * fix circleci * add localize on translateable sentence(s) * translations: 📚 sync translations with crowdin (binary-com#6671) * Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657) * awaiting variable change, so that double refresh is not needed. * account defaults to different one when server is unavailable * refactoring code * changing position of await Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6672) * Amina/ social_icons_text_update (binary-com#6653) * update common.scss * added specific class * Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644) * add_stockes_and_indices_in_compare_mt5_accounts * update_message * change_content_for_non_EU_clients * remove dot at the end of the sentence * add_micro_lots_to_EU_clients * Add Localize to strings (binary-com#6667) Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> * mitchell/modifing profit table alignment (binary-com#6613) * modifyinh profit table alignment * fixed on mobile * translations: 📚 sync translations with crowdin (binary-com#6673) * Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666) * expanding regex with unicode filtering. * refactoring code Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6675) * [Staging] Remove survey pop up (binary-com#6676) * Removed survey pop up * removed the pop up file * translations: 📚 sync translations with crowdin (binary-com#6677) * cancel action Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com> Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com> Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com> Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com> Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>
ali-fs
added a commit
to ali-fs/binary-static
that referenced
this pull request
Jul 15, 2021
* add automatic translation action (binary-com#6649) * Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637) * added a survey for English, Spanish and Portuguese * added the survey code snippet * --- * update english survey snippet * translations: 📚 sync translations with crowdin (binary-com#6652) * Prince/ Incorrect error message payment agent transfer (binary-com#6627) * Chore: added validation condition under numbers * Chore: Lint Fix * Chore: Applied form validation on payment agent transfer form * translations: 📚 sync translations with crowdin (binary-com#6656) * Amina/invalid_characters_on_barriers_mobile (binary-com#6645) * input type changed * test * linting fix * removed PA availability notice (binary-com#6639) * percentage_updated (binary-com#6642) * translations: 📚 sync translations with crowdin (binary-com#6658) * translations: 📚 sync translations with crowdin (binary-com#6659) * Akmal / Add responsiveness to last digit stats title (binary-com#6636) * Add responsiveness to last digit stats title * Remove extra padding * Akmal / Disable purchase button when there is no trading (binary-com#6638) * Disable purchase button when there is no trading * Add more spaces * Add client logged in check * translations: 📚 sync translations with crowdin (binary-com#6660) * Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662) This reverts commit 022998e. * translations: 📚 sync translations with crowdin (binary-com#6663) * translations: 📚 sync translations with crowdin (binary-com#6664) * Kevin/Account closure peding withdrawal(s) error message (binary-com#6620) * account closure * fix circleci * add localize on translateable sentence(s) * translations: 📚 sync translations with crowdin (binary-com#6671) * Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657) * awaiting variable change, so that double refresh is not needed. * account defaults to different one when server is unavailable * refactoring code * changing position of await Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6672) * Amina/ social_icons_text_update (binary-com#6653) * update common.scss * added specific class * Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644) * add_stockes_and_indices_in_compare_mt5_accounts * update_message * change_content_for_non_EU_clients * remove dot at the end of the sentence * add_micro_lots_to_EU_clients * Add Localize to strings (binary-com#6667) Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> * mitchell/modifing profit table alignment (binary-com#6613) * modifyinh profit table alignment * fixed on mobile * translations: 📚 sync translations with crowdin (binary-com#6673) * Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666) * expanding regex with unicode filtering. * refactoring code Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6675) * [Staging] Remove survey pop up (binary-com#6676) * Removed survey pop up * removed the pop up file * translations: 📚 sync translations with crowdin (binary-com#6677) * 1 Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com> Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com> Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com> Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com> Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>
ali-fs
added a commit
to ali-fs/binary-static
that referenced
this pull request
Jul 15, 2021
* add automatic translation action (binary-com#6649) * Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637) * added a survey for English, Spanish and Portuguese * added the survey code snippet * --- * update english survey snippet * translations: 📚 sync translations with crowdin (binary-com#6652) * Prince/ Incorrect error message payment agent transfer (binary-com#6627) * Chore: added validation condition under numbers * Chore: Lint Fix * Chore: Applied form validation on payment agent transfer form * translations: 📚 sync translations with crowdin (binary-com#6656) * Amina/invalid_characters_on_barriers_mobile (binary-com#6645) * input type changed * test * linting fix * removed PA availability notice (binary-com#6639) * percentage_updated (binary-com#6642) * translations: 📚 sync translations with crowdin (binary-com#6658) * translations: 📚 sync translations with crowdin (binary-com#6659) * Akmal / Add responsiveness to last digit stats title (binary-com#6636) * Add responsiveness to last digit stats title * Remove extra padding * Akmal / Disable purchase button when there is no trading (binary-com#6638) * Disable purchase button when there is no trading * Add more spaces * Add client logged in check * translations: 📚 sync translations with crowdin (binary-com#6660) * Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662) This reverts commit 022998e. * translations: 📚 sync translations with crowdin (binary-com#6663) * translations: 📚 sync translations with crowdin (binary-com#6664) * Kevin/Account closure peding withdrawal(s) error message (binary-com#6620) * account closure * fix circleci * add localize on translateable sentence(s) * translations: 📚 sync translations with crowdin (binary-com#6671) * Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657) * awaiting variable change, so that double refresh is not needed. * account defaults to different one when server is unavailable * refactoring code * changing position of await Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6672) * Amina/ social_icons_text_update (binary-com#6653) * update common.scss * added specific class * Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644) * add_stockes_and_indices_in_compare_mt5_accounts * update_message * change_content_for_non_EU_clients * remove dot at the end of the sentence * add_micro_lots_to_EU_clients * Add Localize to strings (binary-com#6667) Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> * mitchell/modifing profit table alignment (binary-com#6613) * modifyinh profit table alignment * fixed on mobile * translations: 📚 sync translations with crowdin (binary-com#6673) * Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666) * expanding regex with unicode filtering. * refactoring code Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6675) * [Staging] Remove survey pop up (binary-com#6676) * Removed survey pop up * removed the pop up file * translations: 📚 sync translations with crowdin (binary-com#6677) * 1 Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com> Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com> Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com> Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com> Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code does recognise when a server on an account is down, and switches to a different one where the server is up. Although, the code doesn't wait for the account change (Client.get() function), hence you receive a blank page and have to refresh a second time to see the eventual change.