Amina/ social_icons_text_update #6653

amina-deriv · 2021-07-05T11:27:56Z

No description provided.

vercel · 2021-07-05T11:28:00Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/binary-static/C3jU8rHQsmpv2WYgYfZcxdob1WHs
✅ Preview: https://binary-static-git-fork-amina-deriv-socialicontextfix.binary.sx

github-actions · 2021-07-05T11:31:16Z

A production App ID was automatically generated for this PR. (log)

PR test: Amina/ social_icons_text_update #6653
URLs:
- w/ App ID + Server: https://binary-static-git-fork-amina-deriv-socialicontextfix.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=27915
- Original: https://binary-static-git-fork-amina-deriv-socialicontextfix.binary.sx/en/logged_inws.html
App ID: 27915

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/binary-static/pull/6653](https://github.com/binary-com/binary-static/pull/6653)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-amina-deriv-socialicontextfix.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=27915
    - **Original**: https://binary-static-git-fork-amina-deriv-socialicontextfix.binary.sx/en/logged_inws.html
- **App ID**: `27915`

akmal-deriv · 2021-07-06T02:07:11Z

src/sass/_common/common.scss

@@ -772,7 +772,7 @@ li strong.margin-right {
        background-color: $COLOR_GRAY;
    }
    .name {
-        text-transform: capitalize;
+        text-transform: capitalize !important;


Hi, I don't think this change would fix the mentioned issue with translation. Can we check with translation team whether these social network names are translated?

Hi @akmal-binary, We are not translating social icon text in our sites. On checking with the QAteam, the actual issue is that for few languages, the social icon text starts with a lowercase letter.

Alright, could you also mention this on the redmine card, because later it might cause confusions among QA team.

sure. Thank you.

thanks @akmal-binary for headsup , i was actually confused , i thought we are going to translate the social media button 😅 .
@amina-deriv i will update the remd card description as totally miss-leading 😄

merging master

* add automatic translation action (binary-com#6649) * Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637) * added a survey for English, Spanish and Portuguese * added the survey code snippet * --- * update english survey snippet * translations: 📚 sync translations with crowdin (binary-com#6652) * Prince/ Incorrect error message payment agent transfer (binary-com#6627) * Chore: added validation condition under numbers * Chore: Lint Fix * Chore: Applied form validation on payment agent transfer form * translations: 📚 sync translations with crowdin (binary-com#6656) * Amina/invalid_characters_on_barriers_mobile (binary-com#6645) * input type changed * test * linting fix * removed PA availability notice (binary-com#6639) * percentage_updated (binary-com#6642) * translations: 📚 sync translations with crowdin (binary-com#6658) * translations: 📚 sync translations with crowdin (binary-com#6659) * Akmal / Add responsiveness to last digit stats title (binary-com#6636) * Add responsiveness to last digit stats title * Remove extra padding * Akmal / Disable purchase button when there is no trading (binary-com#6638) * Disable purchase button when there is no trading * Add more spaces * Add client logged in check * translations: 📚 sync translations with crowdin (binary-com#6660) * Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662) This reverts commit 022998e. * translations: 📚 sync translations with crowdin (binary-com#6663) * translations: 📚 sync translations with crowdin (binary-com#6664) * Kevin/Account closure peding withdrawal(s) error message (binary-com#6620) * account closure * fix circleci * add localize on translateable sentence(s) * translations: 📚 sync translations with crowdin (binary-com#6671) * Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657) * awaiting variable change, so that double refresh is not needed. * account defaults to different one when server is unavailable * refactoring code * changing position of await Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6672) * Amina/ social_icons_text_update (binary-com#6653) * update common.scss * added specific class * Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644) * add_stockes_and_indices_in_compare_mt5_accounts * update_message * change_content_for_non_EU_clients * remove dot at the end of the sentence * add_micro_lots_to_EU_clients * Add Localize to strings (binary-com#6667) Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> * mitchell/modifing profit table alignment (binary-com#6613) * modifyinh profit table alignment * fixed on mobile * translations: 📚 sync translations with crowdin (binary-com#6673) * Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666) * expanding regex with unicode filtering. * refactoring code Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6675) * [Staging] Remove survey pop up (binary-com#6676) * Removed survey pop up * removed the pop up file * translations: 📚 sync translations with crowdin (binary-com#6677) * cancel action Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com> Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com> Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com> Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com> Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>

* add automatic translation action (binary-com#6649) * Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637) * added a survey for English, Spanish and Portuguese * added the survey code snippet * --- * update english survey snippet * translations: 📚 sync translations with crowdin (binary-com#6652) * Prince/ Incorrect error message payment agent transfer (binary-com#6627) * Chore: added validation condition under numbers * Chore: Lint Fix * Chore: Applied form validation on payment agent transfer form * translations: 📚 sync translations with crowdin (binary-com#6656) * Amina/invalid_characters_on_barriers_mobile (binary-com#6645) * input type changed * test * linting fix * removed PA availability notice (binary-com#6639) * percentage_updated (binary-com#6642) * translations: 📚 sync translations with crowdin (binary-com#6658) * translations: 📚 sync translations with crowdin (binary-com#6659) * Akmal / Add responsiveness to last digit stats title (binary-com#6636) * Add responsiveness to last digit stats title * Remove extra padding * Akmal / Disable purchase button when there is no trading (binary-com#6638) * Disable purchase button when there is no trading * Add more spaces * Add client logged in check * translations: 📚 sync translations with crowdin (binary-com#6660) * Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662) This reverts commit 022998e. * translations: 📚 sync translations with crowdin (binary-com#6663) * translations: 📚 sync translations with crowdin (binary-com#6664) * Kevin/Account closure peding withdrawal(s) error message (binary-com#6620) * account closure * fix circleci * add localize on translateable sentence(s) * translations: 📚 sync translations with crowdin (binary-com#6671) * Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657) * awaiting variable change, so that double refresh is not needed. * account defaults to different one when server is unavailable * refactoring code * changing position of await Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6672) * Amina/ social_icons_text_update (binary-com#6653) * update common.scss * added specific class * Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644) * add_stockes_and_indices_in_compare_mt5_accounts * update_message * change_content_for_non_EU_clients * remove dot at the end of the sentence * add_micro_lots_to_EU_clients * Add Localize to strings (binary-com#6667) Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> * mitchell/modifing profit table alignment (binary-com#6613) * modifyinh profit table alignment * fixed on mobile * translations: 📚 sync translations with crowdin (binary-com#6673) * Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666) * expanding regex with unicode filtering. * refactoring code Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> * translations: 📚 sync translations with crowdin (binary-com#6675) * [Staging] Remove survey pop up (binary-com#6676) * Removed survey pop up * removed the pop up file * translations: 📚 sync translations with crowdin (binary-com#6677) * 1 Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com> Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com> Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com> Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local> Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com> Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email> Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>

vercel bot deployed to Preview July 5, 2021 11:28 View deployment

vercel bot deployed to Preview July 5, 2021 12:21 View deployment

vercel bot deployed to Preview July 5, 2021 12:24 View deployment

update common.scss

42a8d52

amina-deriv force-pushed the social_icon_text_fix branch from 78457e4 to 42a8d52 Compare July 5, 2021 12:24

vercel bot deployed to Preview July 5, 2021 12:26 View deployment

akmal-deriv reviewed Jul 6, 2021

View reviewed changes

akmal-deriv previously approved these changes Jul 6, 2021

View reviewed changes

amina-deriv added 2 commits July 6, 2021 12:38

Merge branch 'master' into social_icon_text_fix

201dadd

merging master

added specific class

90e08af

amina-deriv dismissed akmal-deriv’s stale review via 90e08af July 6, 2021 09:01

vercel bot deployed to Preview July 6, 2021 09:02 View deployment

akmal-deriv approved these changes Jul 7, 2021

View reviewed changes

mamali-fs merged commit 5310d6f into binary-com:master Jul 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Amina/ social_icons_text_update #6653

Amina/ social_icons_text_update #6653

Uh oh!

amina-deriv commented Jul 5, 2021

Uh oh!

vercel bot commented Jul 5, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Jul 5, 2021 •

edited

Loading

Uh oh!

akmal-deriv Jul 6, 2021

Uh oh!

amina-deriv Jul 6, 2021

Uh oh!

akmal-deriv Jul 6, 2021

Uh oh!

amina-deriv Jul 6, 2021

Uh oh!

ridhomard Jul 6, 2021

Uh oh!

Uh oh!

Amina/ social_icons_text_update #6653

Amina/ social_icons_text_update #6653

Uh oh!

Conversation

amina-deriv commented Jul 5, 2021

Uh oh!

vercel bot commented Jul 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akmal-deriv Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

amina-deriv Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

akmal-deriv Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

amina-deriv Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

ridhomard Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vercel bot commented Jul 5, 2021 •

edited

Loading

github-actions bot commented Jul 5, 2021 •

edited

Loading