Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Prince/ Incorrect error message payment agent transfer #6627

Merged
merged 5 commits into from
Jul 6, 2021
Merged

Prince/ Incorrect error message payment agent transfer #6627

merged 5 commits into from
Jul 6, 2021

Conversation

prince-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jun 22, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/binary-static/6PfccpkDt717CxmRKsfWfgtzRcJg
✅ Preview: https://binary-static-git-fork-prince-deriv-incorrecterrormessag-7ba362.binary.sx

@github-actions
Copy link

github-actions bot commented Jun 22, 2021 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/binary-static/pull/6627](https://github.com/binary-com/binary-static/pull/6627)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-prince-deriv-incorrecterrormessag-7ba362.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=28003
    - **Original**: https://binary-static-git-fork-prince-deriv-incorrecterrormessag-7ba362.binary.sx/en/logged_inws.html
- **App ID**: `28003`

@prince-deriv prince-deriv force-pushed the incorrect_error_message_pa_transfer branch from d73af1b to bcefd53 Compare June 22, 2021 11:08
carolsachdeva
carolsachdeva reviewed Jun 23, 2021
View reviewed changes
src/javascript/app/common/form_validation.js
@@ -231,13 +231,21 @@ const Validation = (() => {
message = localize('Should be less than [_1]', addComma(options.max, options.format_money ? getDecimalPlaces(Client.get('currency')) : undefined));
}

// Priority Validation
if ('balance' in options && isLessThanBalance(value, options)) {
is_ok = false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this variable to something clearer. Like is_what_ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Carol IMO we can leave it as it is otherwise we will be needing to change the variable name in the entire project. The whole validation helper have different functions inside that use the same is_ok variable.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can leave it as it is now but we should consider better variables.

carolsachdeva
carolsachdeva previously approved these changes Jun 27, 2021
View reviewed changes
@mamali-fs mamali-fs merged commit 00c93df into binary-com:master Jul 6, 2021
ali-fs added a commit to ali-fs/binary-static that referenced this pull request Jul 15, 2021
@ali-fs @alamin-deriv
@DerivFE @prince-deriv @amina-deriv @akmal-deriv @mamali-fs @virtualpowwa @hubert-deriv @mahdiyeh-deriv @mitchell-deriv
Action cancellation (#20)
7b803ab 
* add automatic translation action (binary-com#6649)

* Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637)

* added a survey for English, Spanish and Portuguese

* added the survey code snippet

* ---

* update english survey snippet

* translations: 📚 sync translations with crowdin (binary-com#6652)

* Prince/ Incorrect error message payment agent transfer (binary-com#6627)

* Chore: added validation condition under numbers

* Chore: Lint Fix

* Chore: Applied form validation on payment agent transfer form

* translations: 📚 sync translations with crowdin (binary-com#6656)

* Amina/invalid_characters_on_barriers_mobile (binary-com#6645)

* input type changed

* test

* linting fix

* removed PA availability notice (binary-com#6639)

* percentage_updated (binary-com#6642)

* translations: 📚 sync translations with crowdin (binary-com#6658)

* translations: 📚 sync translations with crowdin (binary-com#6659)

* Akmal / Add responsiveness to last digit stats title (binary-com#6636)

* Add responsiveness to last digit stats title

* Remove extra padding

* Akmal / Disable purchase button when there is no trading (binary-com#6638)

* Disable purchase button when there is no trading

* Add more spaces

* Add client logged in check

* translations: 📚 sync translations with crowdin (binary-com#6660)

* Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662)

This reverts commit 022998e.

* translations: 📚 sync translations with crowdin (binary-com#6663)

* translations: 📚 sync translations with crowdin (binary-com#6664)

* Kevin/Account closure peding withdrawal(s) error message (binary-com#6620)

* account closure

* fix circleci

* add localize on translateable sentence(s)

* translations: 📚 sync translations with crowdin (binary-com#6671)

* Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657)

* awaiting variable change, so that double refresh is not needed.

* account defaults to different one when server is unavailable

* refactoring code

* changing position of await

Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>

* translations: 📚 sync translations with crowdin (binary-com#6672)

* Amina/ social_icons_text_update (binary-com#6653)

* update common.scss

* added specific class

* Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644)

* add_stockes_and_indices_in_compare_mt5_accounts

* update_message

* change_content_for_non_EU_clients

* remove dot at the end of the sentence

* add_micro_lots_to_EU_clients

* Add Localize to strings (binary-com#6667)

Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email>

* mitchell/modifing profit table alignment (binary-com#6613)

* modifyinh profit table alignment

* fixed on mobile

* translations: 📚 sync translations with crowdin (binary-com#6673)

* Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666)

* expanding regex with unicode filtering.

* refactoring code

Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>

* translations: 📚 sync translations with crowdin (binary-com#6675)

* [Staging] Remove survey pop up (binary-com#6676)

* Removed survey pop up

* removed the pop up file

* translations: 📚 sync translations with crowdin (binary-com#6677)

* cancel action

Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com>
Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com>
Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com>
Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com>
Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com>
Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com>
Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>
Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com>
Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email>
Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>
ali-fs added a commit to ali-fs/binary-static that referenced this pull request Jul 15, 2021
@ali-fs @alamin-deriv
@DerivFE @prince-deriv @amina-deriv @akmal-deriv @mamali-fs @virtualpowwa @hubert-deriv @mahdiyeh-deriv @mitchell-deriv
Acation 1 (#21)
b90094c 
* add automatic translation action (binary-com#6649)

* Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637)

* added a survey for English, Spanish and Portuguese

* added the survey code snippet

* ---

* update english survey snippet

* translations: 📚 sync translations with crowdin (binary-com#6652)

* Prince/ Incorrect error message payment agent transfer (binary-com#6627)

* Chore: added validation condition under numbers

* Chore: Lint Fix

* Chore: Applied form validation on payment agent transfer form

* translations: 📚 sync translations with crowdin (binary-com#6656)

* Amina/invalid_characters_on_barriers_mobile (binary-com#6645)

* input type changed

* test

* linting fix

* removed PA availability notice (binary-com#6639)

* percentage_updated (binary-com#6642)

* translations: 📚 sync translations with crowdin (binary-com#6658)

* translations: 📚 sync translations with crowdin (binary-com#6659)

* Akmal / Add responsiveness to last digit stats title (binary-com#6636)

* Add responsiveness to last digit stats title

* Remove extra padding

* Akmal / Disable purchase button when there is no trading (binary-com#6638)

* Disable purchase button when there is no trading

* Add more spaces

* Add client logged in check

* translations: 📚 sync translations with crowdin (binary-com#6660)

* Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662)

This reverts commit 022998e.

* translations: 📚 sync translations with crowdin (binary-com#6663)

* translations: 📚 sync translations with crowdin (binary-com#6664)

* Kevin/Account closure peding withdrawal(s) error message (binary-com#6620)

* account closure

* fix circleci

* add localize on translateable sentence(s)

* translations: 📚 sync translations with crowdin (binary-com#6671)

* Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657)

* awaiting variable change, so that double refresh is not needed.

* account defaults to different one when server is unavailable

* refactoring code

* changing position of await

Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>

* translations: 📚 sync translations with crowdin (binary-com#6672)

* Amina/ social_icons_text_update (binary-com#6653)

* update common.scss

* added specific class

* Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644)

* add_stockes_and_indices_in_compare_mt5_accounts

* update_message

* change_content_for_non_EU_clients

* remove dot at the end of the sentence

* add_micro_lots_to_EU_clients

* Add Localize to strings (binary-com#6667)

Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email>

* mitchell/modifing profit table alignment (binary-com#6613)

* modifyinh profit table alignment

* fixed on mobile

* translations: 📚 sync translations with crowdin (binary-com#6673)

* Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666)

* expanding regex with unicode filtering.

* refactoring code

Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>

* translations: 📚 sync translations with crowdin (binary-com#6675)

* [Staging] Remove survey pop up (binary-com#6676)

* Removed survey pop up

* removed the pop up file

* translations: 📚 sync translations with crowdin (binary-com#6677)

* 1

Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com>
Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com>
Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com>
Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com>
Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com>
Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com>
Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>
Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com>
Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email>
Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>
ali-fs added a commit to ali-fs/binary-static that referenced this pull request Jul 15, 2021
@ali-fs @alamin-deriv
@DerivFE @prince-deriv @amina-deriv @akmal-deriv @mamali-fs @virtualpowwa @hubert-deriv @mahdiyeh-deriv @mitchell-deriv
Acation 2 (#22)
a362002 
* add automatic translation action (binary-com#6649)

* Al-amin/36621/added a survey Pop up for English, Spanish and Portuguese (binary-com#6637)

* added a survey for English, Spanish and Portuguese

* added the survey code snippet

* ---

* update english survey snippet

* translations: 📚 sync translations with crowdin (binary-com#6652)

* Prince/ Incorrect error message payment agent transfer (binary-com#6627)

* Chore: added validation condition under numbers

* Chore: Lint Fix

* Chore: Applied form validation on payment agent transfer form

* translations: 📚 sync translations with crowdin (binary-com#6656)

* Amina/invalid_characters_on_barriers_mobile (binary-com#6645)

* input type changed

* test

* linting fix

* removed PA availability notice (binary-com#6639)

* percentage_updated (binary-com#6642)

* translations: 📚 sync translations with crowdin (binary-com#6658)

* translations: 📚 sync translations with crowdin (binary-com#6659)

* Akmal / Add responsiveness to last digit stats title (binary-com#6636)

* Add responsiveness to last digit stats title

* Remove extra padding

* Akmal / Disable purchase button when there is no trading (binary-com#6638)

* Disable purchase button when there is no trading

* Add more spaces

* Add client logged in check

* translations: 📚 sync translations with crowdin (binary-com#6660)

* Revert "Amina/invalid_characters_on_barriers_mobile (binary-com#6645)" (binary-com#6662)

This reverts commit 022998e.

* translations: 📚 sync translations with crowdin (binary-com#6663)

* translations: 📚 sync translations with crowdin (binary-com#6664)

* Kevin/Account closure peding withdrawal(s) error message (binary-com#6620)

* account closure

* fix circleci

* add localize on translateable sentence(s)

* translations: 📚 sync translations with crowdin (binary-com#6671)

* Hubert / Have to refresh MT5 dashboard twice when a server is down, to see dashboard again. (binary-com#6657)

* awaiting variable change, so that double refresh is not needed.

* account defaults to different one when server is unavailable

* refactoring code

* changing position of await

Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>

* translations: 📚 sync translations with crowdin (binary-com#6672)

* Amina/ social_icons_text_update (binary-com#6653)

* update common.scss

* added specific class

* Mahdiyeh/ add_stockes_and_indices_in_compare_mt5_accounts (binary-com#6644)

* add_stockes_and_indices_in_compare_mt5_accounts

* update_message

* change_content_for_non_EU_clients

* remove dot at the end of the sentence

* add_micro_lots_to_EU_clients

* Add Localize to strings (binary-com#6667)

Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email>

* mitchell/modifing profit table alignment (binary-com#6613)

* modifyinh profit table alignment

* fixed on mobile

* translations: 📚 sync translations with crowdin (binary-com#6673)

* Hubert / Invalid unicode characters don't get validated in register email input. (binary-com#6666)

* expanding regex with unicode filtering.

* refactoring code

Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>

* translations: 📚 sync translations with crowdin (binary-com#6675)

* [Staging] Remove survey pop up (binary-com#6676)

* Removed survey pop up

* removed the pop up file

* translations: 📚 sync translations with crowdin (binary-com#6677)

* 1

Co-authored-by: Al-amin Abdulkareem <81704069+alamin-deriv@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: prince-deriv <82309725+prince-deriv@users.noreply.github.com>
Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com>
Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com>
Co-authored-by: reza-fs <53177016+reza-fs@users.noreply.github.com>
Co-authored-by: Kevin <70131533+kevinw-binary@users.noreply.github.com>
Co-authored-by: hubert-deriv <80688204+hubert-deriv@users.noreply.github.com>
Co-authored-by: Hubert Koster <hubertkoster@Huberts-MacBook-Pro.local>
Co-authored-by: mahdiyeh-fs <82078941+mahdiyeh-fs@users.noreply.github.com>
Co-authored-by: Mohammadreza Ghorbani <reza@firstsource.email>
Co-authored-by: mitchell-deriv <79144418+mitchell-deriv@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carolsachdeva carolsachdeva carolsachdeva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prince-deriv @carolsachdeva @mamali-fs