This repository was archived by the owner on Feb 22, 2024. It is now read-only.
Mahdiyeh/ remove_cryptocurrency_market #6570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmal-deriv
previously approved these changes
Jun 3, 2021
matin-deriv
suggested changes
Jun 4, 2021
There was a problem hiding this comment.
The reason behind disabling cryptocurrencies is that Crypto only supports Multipliers in contracts_for, it is the same case for Jump indices. Since we don't have Multipliers in platforms other than Deriv-app, we are trying to hide based on the markets, but it is best to filter out based on shortcodes using regex to make sure it will handle other cases and avoid double work in future.
So I suggest using (?:JD[0-9])|(?:cry_[A-Z])\ to filter out shortcodes. JD for Jump indices and cry for Cryptos.
Feel free to have a look into Zaki's changes in this PR https://redmine.deriv.cloud/issues/30826
mahdiyeh-deriv
force-pushed
the
remove_ctyptocurrency_market
branch
2 times, most recently
from
7d03e21 to
c98072d
Compare
mahdiyeh-deriv
force-pushed
the
remove_ctyptocurrency_market
branch
from
7aca9bd to
1fcb150
Compare
matin-deriv
approved these changes
Jun 8, 2021
negarn
approved these changes
Jun 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.