Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

mohammad/new_trading #1408

Merged
merged 40 commits into from
Sep 8, 2016
Merged

Conversation

mohammad-deriv
Copy link
Contributor

No description provided.

@mohammad-deriv mohammad-deriv force-pushed the mohammad/new_trading branch 4 times, most recently from 3fc4e22 to be412fb Compare August 21, 2016 14:42
@mohammad-deriv mohammad-deriv force-pushed the mohammad/new_trading branch 4 times, most recently from 4d68191 to 3986c13 Compare August 26, 2016 10:06
@eugene-eeo
Copy link
Contributor

very rough look over the code, maybe my final code review 😁 not_first_request, well... it doesn't feel right. maybe we should use is_first_request? that way you can just set it equal to true initially, (saving one line! of code) and it reads better.

@mohammad-deriv
Copy link
Contributor Author

@eugene-eeo I agree. I meant to change it, but I've forgotten. Thanks for reminding me.
Wish you the best.

@mohammad-deriv mohammad-deriv force-pushed the mohammad/new_trading branch 4 times, most recently from cd8a0d5 to 8a08f34 Compare September 5, 2016 07:48
font-weight: bold;
line-height: 0px;
line-height: 35px;
font-size: 26px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a font-size from constants we can use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

@ashkanx ashkanx merged commit 394476d into binary-com:master Sep 8, 2016
@ashkanx ashkanx deleted the mohammad/new_trading branch September 8, 2016 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants