Prince/ Incorrect error message payment agent transfer (#6627)

* Chore: added validation condition under numbers

* Chore: Lint Fix

* Chore: Applied form validation on payment agent transfer form

Author: prince-deriv

src/javascript/app/common/form_validation.js

@@ -231,13 +231,21 @@ const Validation = (() => {
             message = localize('Should be less than [_1]', addComma(options.max, options.format_money ? getDecimalPlaces(Client.get('currency')) : undefined));
         }
 
+        // Priority Validation
+        if ('balance' in options && isLessThanBalance(value, options)) {
+            is_ok   = false;
+            message = localize('Insufficient balance.');
+        }
+
         ValidatorsMap.get().number.message = message;
         return is_ok;
     };
 
     const isMoreThanMax = (value, options) =>
         (options.type === 'float' ? +value > +options.max : compareBigUnsignedInt(value, options.max) === 1);
 
+    const isLessThanBalance = (value,options) => options.balance < value;
+
     const validTaxID = (value, options, field) => {
         // input is valid in API regex but may not be valid for country regex
         if (/^[a-zA-Z0-9]*[\w-]*$/.test(value)) {

src/javascript/app/pages/cashier/payment_agent_withdraw.js

@@ -108,7 +108,7 @@ const PaymentAgentWithdraw = (() => {
             $form.find('.wrapper-row-agent').find('label').append($('<span />', { text: '*', class: 'required_field_asterisk' }));
             $form.find('label[for="txtAmount"]').text(`${localize('Amount in')} ${Currency.getCurrencyDisplayCode(currency)}`);
             FormManager.init(form_id, [
-                { selector: field_ids.txt_amount,      validations: ['req', ['number', { type: 'float', decimals: Currency.getDecimalPlaces(currency), min, max }], ['custom', { func: () => +Client.get('balance') >= +$txt_amount.val(), message: localize('Insufficient balance.') }]], request_field: 'amount' },
+                { selector: field_ids.txt_amount,      validations: ['req', ['number', { type: 'float', decimals: Currency.getDecimalPlaces(currency), min, max, balance: Client.get('balance') }]], request_field: 'amount' },
                 { selector: field_ids.txt_payment_ref, validations: [['length', { min: 0, max: 30 }], ['regular', { regex: /^[0-9A-Za-z .,'-]{0,30}$/, message: localize('Only letters, numbers, space, hyphen, period, comma, and apostrophe are allowed.') }]],                 request_field: 'description', value: () => $txt_payment_ref.val() ? payment_ref_prefix + $txt_payment_ref.val() : '' },
 
                 { request_field: 'currency',              value: currency },

src/javascript/app/pages/user/account/payment_agent_transfer/payment_agent_transfer.js

@@ -61,7 +61,7 @@ const PaymentAgentTransfer = (() => {
 
         FormManager.init(form_id, [
             { selector: '#client_id', validations: ['req', ['regular', { regex: /^\w+\d+$/, message: localize('Please enter a valid Login ID.') }]], request_field: 'transfer_to' },
-            { selector: '#amount',    validations: ['req', ['number', { type: 'float', decimals: getDecimalPlaces(currency), min: pa ? pa.min_withdrawal : 10, max: max_withdrawal(balance, pa, 2000) }], ['custom', { func: () => +Client.get('balance') >= +$('#amount').val(), message: localize('Insufficient balance.') }]] },
+            { selector: '#amount',    validations: ['req', ['number', { type: 'float', decimals: getDecimalPlaces(currency), min: pa ? pa.min_withdrawal : 10, max: max_withdrawal(balance, pa, 2000),balance: Client.get('balance') }]] },
             { selector: '#description', validations: ['general'] },
 
             { request_field: 'dry_run', value: 1 },