Skip to content

build(fix): update semver to trigger postTargets feature #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2021

Conversation

dianjuar
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://www.conventionalcommits.org/en/v1.0.0/
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Both workspaces were tested Angular and Nx

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related change
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

The Semver's postTarget feature did not run the executor with the suitable options; for some reason, all options with default values had as value true. For our scenario, dryRun and noBuild were true, leading to unwanted behavior.

What is the new behavior?

Updating Semver to the last version solve this problem

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dianjuar dianjuar added bug Something isn't working Hacktoberfest labels Oct 30, 2021
@dianjuar dianjuar merged commit 95af9d3 into master Oct 30, 2021
@dianjuar dianjuar deleted the update-semver branch October 30, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant