Validate data element constraints #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaya-mankad
approved these changes
Apr 16, 2025
| self.data_element: DataElement | ||
|
|
||
| def resolve(self): | ||
| assert isinstance(self.parent_data_element.data_type, DataGroupType) |
There was a problem hiding this comment.
Since init covers this condition, the assert is never triggered.
There was a problem hiding this comment.
It's never triggered, but it silences MyPy warnings. Maybe there is a better way to manage those?
There was a problem hiding this comment.
Oh yeah, it's this: # type: ignore on the offending line.
There was a problem hiding this comment.
We could ignore it, but the assert gives the type checker (and the IDE) additional context to help with downstream type checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.