Skip to content

feat(checkout): CHECKOUT-9468 convert SingleShippingForm #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

feat(checkout): CHECKOUT-9468 convert SingleShippingForm #2582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb627f2
feat(checkout): CHECKOUT-9468 convert SingleShippingForm
richapatel1510 Sep 17, 2025
f226986
feat(checkout): CHECKOUT-9468 refactor
richapatel1510 Sep 18, 2025
9812eb6
feat(checkout): CHECKOUT-9468 refactor
richapatel1510 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/core/src/app/shipping/ShippingForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
type CheckoutParams,
type CheckoutSelectors,
type Consignment,
type CustomerRequestOptions,
type FormField,
type RequestOptions,
type ShippingInitializeOptions,
Expand Down Expand Up @@ -42,7 +41,6 @@ export interface ShippingFormProps {
onSignIn(): void;
onSingleShippingSubmit(values: SingleShippingFormValues): void;
onUnhandledError(error: Error): void;
signOut(options?: CustomerRequestOptions): void;
updateAddress(
address: Partial<Address>,
options: RequestOptions<CheckoutParams>,
Expand All @@ -69,7 +67,6 @@ const ShippingForm = ({
onUnhandledError,
shippingAddress,
shouldShowOrderComments,
signOut,
updateAddress,
isShippingStepPending,
isInitialValueLoaded,
Expand Down Expand Up @@ -121,15 +118,13 @@ const ShippingForm = ({
isBillingSameAsShipping={isBillingSameAsShipping}
isInitialValueLoaded={isInitialValueLoaded}
isLoading={isLoading}
isMultiShippingMode={isMultiShippingMode}
isShippingStepPending={isShippingStepPending}
methodId={methodId}
onSubmit={onSingleShippingSubmit}
onUnhandledError={onUnhandledError}
shippingAddress={shippingAddress}
shippingFormRenderTimestamp={shippingFormRenderTimestamp}
shouldShowOrderComments={shouldShowOrderComments}
signOut={signOut}
updateAddress={updateAddress}
/>
);
Expand Down
Loading