Skip to content

RUBY-17: Add frozen_string_literal magic comment to all files #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

splittingred
Copy link
Member

What?

Adds frozen_string_literal: true directive to all files, allowing Ruby to refer to allocate them once and refer in its hash table to that same string, reducing overall memory usage for this library.

Also moves strings to constants where appropriate to do so.

@splittingred splittingred requested review from a team February 24, 2022 21:40
@splittingred splittingred self-assigned this Feb 24, 2022
@splittingred splittingred requested a review from bc-chaz February 24, 2022 21:40
Copy link
Contributor

@j05h j05h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@splittingred splittingred merged commit 4fd92e8 into master Feb 24, 2022
@splittingred splittingred deleted the RUBY-17 branch February 24, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants