Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous TMT label extraction logic #139

Open
fabianegli opened this issue Aug 26, 2022 · 0 comments
Open

Erroneous TMT label extraction logic #139

fabianegli opened this issue Aug 26, 2022 · 0 comments

Comments

@fabianegli
Copy link
Collaborator

label_list = sorted(label)

Sorting the default label results in label_list being ['2', 'M', 'T', 'T'] with a length of 4 which then probably leads to leads being true and we have a 6-plex form a 2-plex.

I think the whole label extraction should be more stringent and fail on unknown input with a note that an issue should be opened in this repo to adjust for new labels (and fix bugs). Guessing could lead to issues that are hard to diagnose by users and errors might even go unnoticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant