Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXD010154 instrument/ontology mismatch in sdrf #551

Closed
glormph opened this issue Jun 4, 2021 · 1 comment · Fixed by #553
Closed

PXD010154 instrument/ontology mismatch in sdrf #551

glormph opened this issue Jun 4, 2021 · 1 comment · Fixed by #553
Assignees
@daichengxin

Comments

@glormph
Copy link

glormph commented Jun 4, 2021

Hi,
I'm not sure I'm doing this correctly but I recently encountered the SDRF for PXD010154, which contains files from a "Q Exactive Plus" instrument. But the instrument ontology code was MS:1002526, which is for an "Exactive Plus", without a Q. The correct code would I guess be to use MS:1002634.

I don't know where how this data is generated, but wanted to inform in case it's mismatched in code or DB somewhere.
@ypriverol
Copy link
Member

Tahnks, We will be fix it

@daichengxin daichengxin linked a pull request Jun 8, 2021 that will close this issue
Fixed instrument ontology #553
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daichengxin daichengxin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed instrument ontology daichengxin/proteomics-metadata-standard
3 participants
@ypriverol @glormph @daichengxin