Skip to content

BEP038: Atlas examples #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

BEP038: Atlas examples #501

wants to merge 10 commits into from

Conversation

effigies
Copy link
Contributor

This branch implements examples according to bids-standard/bids-specification#1714 (rendered: https://bids-specification--1714.org.readthedocs.build/en/1714/).

Please make PRs against the bep038 branch, and we will merge this PR as a part of merging BEP038.

@effigies
Copy link
Contributor Author

@oesteban Notes on atlas-suit:

  • atlas-*_description.json does not currently have a file rule. From reading the BEP, it looks like it can occur at any level of the hierarchy, which is not possible with the current structure of file rules. Is it problematic to require it to be found at the dataset root?
  • *_dseg.tsv need to be non-empty files.
  • *_stat-confidence_* - The stat entity is not defined.

Otherwise, this needs very little adjustment to the validator.

@oesteban
Copy link

  • atlas-*_description.json does not currently have a file rule. From reading the BEP, it looks like it can occur at any level of the hierarchy, which is not possible with the current structure of file rules. Is it problematic to require it to be found at the dataset root?

I don't think this should be a problem.

  • *_dseg.tsv need to be non-empty files.

Gotcha, will give them content.

  • *_stat-confidence_* - The stat entity is not defined.

desc then?

@effigies
Copy link
Contributor Author

  • *_stat-confidence_* - The stat entity is not defined.

desc then?

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants