Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex nested path not working with 0.6.2 #12

Closed
ReynerHL opened this issue Jan 27, 2018 · 5 comments
Closed

Complex nested path not working with 0.6.2 #12

ReynerHL opened this issue Jan 27, 2018 · 5 comments

Comments

@ReynerHL
Copy link

ReynerHL commented Jan 27, 2018

In this code example, we are using vue-deepset 0.5.4 with vuex modules and v-model bindings to nested loops in templates. But if we upgrade to the 0.6.2 version, it does not work anymore.

https://codesandbox.io/s/vqmn4olqkl

Yes, we know we are always putting this package to the limits, but this is because we love it :)

@bhoriuchi
Copy link
Owner

seems to be an issue with topath as when using libraryModel[`books.${bookIndex}.fans.${fanIndex}.name`] it works

@bhoriuchi
Copy link
Owner

I rolled back the toPath and vueSet methods to the older code and it resolved the issue. v0.6.3 published to npm. thanks for all your testing!

@ReynerHL
Copy link
Author

Thanks to you, for always being giving a great support to the issues we found.

Just for be clear, this kind of notation:

libraryModel[`books.${bookIndex}.fans.${fanIndex}.name`]

Will be fine for indexing arrays and access objects properties values as well?

@bhoriuchi
Copy link
Owner

Yeah it should be ok. I might export the supporting methods like toPath and get so devs can test them out

@ReynerHL
Copy link
Author

Thanks, we can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants