remove the engine option harder, ensure deprecation warning is tested

bholloway · Jun 9, 2021 · fb09fae · fb09fae
1 parent 08e153c
commit fb09fae
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/packages/resolve-url-loader/index.js b/packages/resolve-url-loader/index.js
@@ -20,7 +20,7 @@ const logToTestHarness = require('./lib/log-to-test-harness');
 const DEPRECATED_OPTIONS = {
   engine: [
     'DEP_RESOLVE_URL_LOADER_OPTION_ENGINE',
-    'the "engine" option has been removed, "postcss" is the only available parser'
+    '"engine" option has been removed, postcss is the only parser used'
   ],
   keepQuery: [
     'DEP_RESOLVE_URL_LOADER_OPTION_KEEP_QUERY',

diff --git a/test/cases/misconfiguration.js b/test/cases/misconfiguration.js
@@ -53,6 +53,36 @@ module.exports = test(
     env({
       ENTRY: join('src', 'index.scss')
     }),
+    testWithOption({ engine: 'postcss' })(
+      testDefault(
+        buildDevNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertDeprecationWarning('"engine" option has been removed'),
+          assertContentDev
+        ),
+        buildProdNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertDeprecationWarning('"engine" option has been removed'),
+          assertContentProd
+        )
+      ),
+      testSilent(
+        buildDevNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertSilence,
+          assertContentDev
+        ),
+        buildProdNormal(
+          assertWebpackOk,
+          assertNoErrors,
+          assertSilence,
+          assertContentProd
+        )
+      )
+    ),
     testWithOption({ attempts: 1 })(
       testDefault(
         buildDevNormal(