Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup/Add Mongo/Mongo Express Docker Compose #9

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Setup/Add Mongo/Mongo Express Docker Compose #9

merged 7 commits into from
Oct 9, 2023

Conversation

kishan-aghera
Copy link
Contributor

@kishan-aghera kishan-aghera commented May 13, 2023 •
edited
Loading

What

Added docker compose setup for PostgreSQL database along with pgAdmin.

bhavik2936
bhavik2936 reviewed Jul 26, 2023
View reviewed changes
Copy link
Owner

@bhavik2936 bhavik2936 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution Kishan!

I have couple of suggestions along with concerns regarding volumes & networks (to specify) in compose file; which I have mentioned below.

@kishan-aghera
Copy link
Contributor Author

@bhavik2936 Please check the added commits to find the solutions to the changes you suggested. Thanks.

@bhavik2936
Copy link
Owner

Thanks for the contribution Kishan, Looks Great!

@bhavik2936 bhavik2936 merged commit 8ad0259 into bhavik2936:main Oct 9, 2023
@kishan-aghera kishan-aghera deleted the mongo branch October 10, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavik2936 bhavik2936 bhavik2936 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishan-aghera @bhavik2936