Generator Feedback

[sakulstra]

We created a very sparse proposal generator accessible via yarn generate

This ticket only exists to collect initial feedback on if this is useful or not & what features would be required to make it more useful.

• figure out how to properly add dates
• more clear flags
• add prompt for missing flags
• add _Test and _Payload suffix for easier readability

[efecarranza]

This is a great tool, really happy for it and excited to use it, it saves a lot of time.

Some things I noticed:

The deployment .s.sol file does not have EthereumScript imported. CreateProposal extends this contract.

The date I'd do as YYYYMMDD rather than YYYYDDMM, I think YYYYMMDD is the standard or at least the most common.

For the -t option, I was expecting it would be the .md file's name, not the title inside of the file.

[efecarranza]

Follow up: Probably makes sense to add _Payload and _Test at the end of the files.

[efecarranza]

In tests, allConfigsAfter still says pre instead of post for the configuration snapshot.
createDiffs() is not added automatically

[sakulstra]

@efecarranza make sure you on latest main, the last issue reported should already be fixed as previously reported by @marczeller (b087f26)

The deployment .s.sol file does not have EthereumScript imported. CreateProposal extends this contract.

Ah this happened in the case Ethereum was not a target 😅 - fixed on newest main

[yonikesel]

Hey, excited to use the tool.
Noticed that when creating an AIP for V2, the CLI expects upper-case "V2" while name generator checks for lower-case "v2".
I created a PR for the fix: PR

[sakulstra]

• generator breaks when there are special characters in the proposal title as it will generate invalid solidity code