Open
Conversation
Two-pass audit covering encoding quality, security, codec currency, HLS/DASH gaps, and mobile compatibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nTwo-pass audit of all 23 FFmpeg transcoding presets covering encoding quality, security, codec currency, HLS/DASH gaps, and mobile compatibility.\n\nDeliverables:\n-
FINDINGS.md— Structured findings (2 Critical, 4 High, 7 Medium, 4 Low) + agent skill improvements + positive observations\n-CLAUDE.md— Improved with full preset inventory tables, codec info, usage patterns, deployment flow, and all gotchas\n\n## Key Findings\n\nCritical:\n- C-1:video_codec_optionsparser uses=but presets use:— profile/level/refs are silently ignored on every transcode\n- C-2:custom_cmdallows arbitrary command injection (cross-repo, lives in CloudTranscode)\n\nHigh:\n- H-1:kindleFireHDX-generic.jsonhas invalid JSON (trailing comma) + missing field — completely broken\n- H-2: No modern codecs (H.265, VP9, AV1) — ~30-50% wasted bandwidth\n- H-3: HLS presets use non-standard resolutions (hls2M outputs 4:3)\n- H-4: No DASH/CMAF presets for Android-native adaptive streaming\n\nMedium: Baseline profile on 1080p/720p, inconsistent frame rates, broken S3 backup workflow, no CI validation, libfdk_aac dependency risk, auto-scale bypasses enlargement check\n\n## Test plan\n\n- [ ] Review FINDINGS.md for accuracy of technical claims\n- [ ] Verify C-1 parser mismatch by testingexplode(\"=\", \"Profile:baseline\")in PHP\n- [ ] Validate H-1 by runningjq . kindleFireHDX-generic.json(should fail)\n- [ ] Confirm HLS resolution claims against Apple HLS Authoring Spec\n- [ ] Check if any legacy device presets are still actively referenced in job configs\n\n🤖 Generated with Claude Code"