Skip to content

Commit f594314

Browse files
committed
Remove unused/unusable unsubscribe since we don't want to unsubscribe
In 0.9 (which this implementation is based on), the instrumentation was `!serialize.active_model_serializers`. rails-api#596 The '!' in the event name meant the event wasn't meant for production. https://github.com/rails/rails/pull/10446/files#r4075679 Since we intend the event for production and have a log subscriber, if we unsubscribe from `render.active_model_serializers`, we'll break other tests that are relying on that event being subscribed.
1 parent ef09c90 commit f594314

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/active_model_serializers/test/serializer.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ def subscribe
6969
end
7070
end
7171

72-
def unsubscribe
73-
ActiveSupport::Notifications.unsubscribe(event_name)
74-
end
75-
7672
private
7773

7874
def matches_class?

0 commit comments

Comments
 (0)