Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further positioning fixes #36

Open
4 tasks done
antony opened this issue Apr 4, 2021 · 1 comment
Open
4 tasks done

Further positioning fixes #36

antony opened this issue Apr 4, 2021 · 1 comment

Comments

@antony
Copy link
Member

antony commented Apr 4, 2021

  • On a very small viewport, make the calendar fullscreen and scrollable
  • Ensure that the time chooser part is no bigger than the overall calendar
  • Make sure button doesn't appear within no-click zone on stupid iPhone
  • On a wide but thin screen, show the side-by-side range picker
@antony
Copy link
Member Author

antony commented Apr 6, 2021

There will be edge cases to this, so leaving here to clean-up. However I think I've got positioning into a working state for now, across a variety of devices and iPhone and iframe.

Remaining tasks are:

  • Clean up positioning code
  • Tests for positioning code (it was trial-and-error, so now I've solidifed it we can go back and add testing)
  • Turn positioning into configuration, and pass it in so we factor in the calendar-width attribute
  • Decide on a "mobile" size, currently we have a mix of 480, 600, and 680
  • Tidy up the fullscreen view by adding some padding on small screens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant