Use single threaded executor for archetype benches#9835
Merged
Conversation
On my machine, this makes the `no_archetype` bench group 20 to 30 times faster. Meaning that most of the runtime was accounted by the multithreaded scheduler. ie: the benchmark was not testing system archetype update, but the overhead of multithreaded scheduling. With this change, the benchmark results are more meaningful. The add_archetypes function is also simplified.
nicopap
added
A-ECS
mockersf
approved these changes
Sep 18, 2023
alice-i-cecile
approved these changes
Sep 18, 2023
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Looks good. Should we make this change for more of our benchmarks?
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective `no_archetype` benchmark group results were very noisy ## Solution Use the `SingeThreaded` executor. On my machine, this makes the `no_archetype` bench group 20 to 30 times faster. Meaning that most of the runtime was accounted by the multithreaded scheduler. ie: the benchmark was not testing system archetype update, but the overhead of multithreaded scheduling. With this change, the benchmark results are more meaningful. The add_archetypes function is also simplified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
no_archetypebenchmark group results were very noisySolution
Use the
SingeThreadedexecutor.On my machine, this makes the
no_archetypebench group 20 to 30 times faster. Meaning that most of the runtime was accounted by the multithreaded scheduler. ie: the benchmark was not testing system archetype update, but the overhead of multithreaded scheduling.With this change, the benchmark results are more meaningful.
The add_archetypes function is also simplified.