Move schedule name into Schedule

[hymm]

Objective

• Move schedule name into Schedule to allow the schedule name to be used for errors and tracing in Schedule methods
• Fixes Schedule build errors should include the schedule in which the problem occurred when reporting problems #9510

Solution

• Move label onto Schedule and adjust api's on World and Schedule to not pass explicit label where it makes sense to.
• add name to errors and tracing.
• Schedule::new now takes a label so either add the label or use Schedule::default which uses a default label. default is mostly used in doc examples and tests.

---

Changelog

• move label onto Schedule to improve error message and logging for schedules.

Migration Guide

Schedule::new and App::add_schedule

// old
let schedule = Schedule::new();
app.add_schedule(MyLabel, schedule);

// new
let schedule = Schedule::new(MyLabel);
app.add_schedule(schedule);

if you aren't inserting the schedule into the world and are using the schedule directly you can use the default constructor which reuses a default label.

// old
let schedule = Schedule::new();
schedule.run(world);

// new
let schedule = Schedule::default();
schedule.run(world);

Schedules:insert

// old
let schedule = Schedule::new();
schedules.insert(MyLabel, schedule);

// new
let schedule = Schedule::new(MyLabel);
schedules.insert(schedule);

World::add_schedule

// old
let schedule = Schedule::new();
world.add_schedule(MyLabel, schedule);

// new
let schedule = Schedule::new(MyLabel);
world.add_schedule(schedule);

[alice-i-cecile]

Very straightforward, but extremely useful for diagnostics.

[joseph-gio]

Should remove_entry still return the label?

[hymm]

I'm not sure if remove_entry has any use. We already have remove, so we should just delete remove_entry if it doesn't. It's slightly useful in that you can get the owned Boxed label for free, but not sure that's worth the added api.

I should switch to using remove here, since we're not using the label.

[joseph-gio]

Fair enough. If #7762 gets merged then we should definitely get rid of remove_entry, since there'd be no benefit to keeping the schedule label.

[joseph-gio]

I have one concern about docs, but otherwise LGTM.

[joseph-gio]

Will this documentation be visible to users?

[alice-i-cecile]

It should be yes. I'll verify before merging though.

[alice-i-cecile]

The docs on the trait impl show up fine :)

[alice-i-cecile]

Looks like merge conflict-y issues: can you rebase and fix this up?

[alice-i-cecile]

@hymm CI is still failing: looks like another use of Schedule was added.

[joseph-gio]

The docs on the trait impl show up fine :)

They show up, but I don't think they'll show up where anyone will see them. It'd have to be on the default fn to be useful, I think.