Fix field visibility for read-only WorldQuery types
#8163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
C-Bug
CGMossa
approved these changes
Mar 22, 2023
james7132
approved these changes
Mar 22, 2023
james7132
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Mar 22, 2023
mockersf
pushed a commit
that referenced
this pull request
Mar 27, 2023
When using the `#[derive(WorldQuery)]` macro, the `ReadOnly` struct generated has default (private) visibility for each field, regardless of the visibility of the original field. For each field of a read-only `WorldQuery` variant, use the visibility of the associated field defined on the original struct.
UkoeHB
pushed a commit
to UkoeHB/bevy
that referenced
this pull request
Sep 10, 2023
When using the `#[derive(WorldQuery)]` macro, the `ReadOnly` struct generated has default (private) visibility for each field, regardless of the visibility of the original field. For each field of a read-only `WorldQuery` variant, use the visibility of the associated field defined on the original struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When using the
#[derive(WorldQuery)]macro, theReadOnlystruct generated has default (private) visibility for each field, regardless of the visibility of the original field.Solution
For each field of a read-only
WorldQueryvariant, use the visibility of the corresponding field defined on the original struct.