-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add TimeUpdateStrategy
resource for manual Time
updating
#6159
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2026889
allow optional update time value in `time_system`
ShinySapphic 8633d97
add `update_with_instant` method for `App`
ShinySapphic 1a1174b
remember to remove `DesiredTime` resource
ShinySapphic 401f5f6
rename `UpdateTime` to `DesiredTime`
ShinySapphic 42d8a78
collapse `else { if ..}` block
ShinySapphic ba82a4a
make `DesiredTime` resource public
ShinySapphic 909d2f8
add `TimeUpdateStrategy` config resource
invalid-email-address 79f603b
add doc comments
ShinySapphic 85f5d9f
call try_recv on `TimeReceiver` for all cases
ShinySapphic 325e3be
remove unused import
ShinySapphic b6ec0dc
Merge branch 'bevyengine:main' into main
ShinySapphic 0cc386f
remove `bevy_time` doc comments in `App`
ShinySapphic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rename
UpdateTime
to DesiredTime
- Loading branch information
commit 401f5f6d10413aae904573efd8eea7019c31981a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this isn't
pub
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. I just assumed since it was going to be inserted from the method that it didn't need to be accessed externally. Now that I think about it, there's probably some use cases where you might want to access it externally so I'll go ahead and make it public.