[Merged by Bors] - gltf: add a name to nodes without names #4396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
force-pushed
the
gltf-default-name
branch
from
be4311a to
6fed02c
Compare
mockersf
added
A-Assets
alice-i-cecile
approved these changes
Apr 3, 2022
jakobhellermann
approved these changes
Apr 3, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
# Objective - Animation is using `Name` to be able to address nodes in an entity free way - When loading random animated gltf files, I noticed some had animations without names sometimes ## Solution - Add default names to all nodes
|
Not blocking, but for scenes with thousands of nodes, allocating strings for each node for each instance of the scene seems like the wrong direction. Maybe (ultimately) "scene entity names" should be tied to the asset and looked up when needed? Or alternatively, we could use copy-on-write strings for names (I didn't mention rust's |
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Animation is using `Name` to be able to address nodes in an entity free way - When loading random animated gltf files, I noticed some had animations without names sometimes ## Solution - Add default names to all nodes
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Animation is using `Name` to be able to address nodes in an entity free way - When loading random animated gltf files, I noticed some had animations without names sometimes ## Solution - Add default names to all nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Nameto be able to address nodes in an entity free waySolution