[Merged by Bors] - Cleanup some outdated parts of ecs_guide #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Mar 26, 2022
DJMcNab
commented
Mar 26, 2022
| // For any type which is `Default`, like `u32` in this example, `FromWorld` creates the default value. | ||
| fn print_at_end_round(mut counter: Local<u32>) { | ||
| *counter += 1; | ||
| println!("In stage 'Last' for the {}th time", *counter); |
There was a problem hiding this comment.
Ideally this would use the correct suffix, but that should probably be part of an external crate. We don't currently depend on (MPL 2.0)ordinal or an equivalent, as far as I know.
|
I'm ready to merge once CI passes and I have a second approval :) |
|
CI failure appears to be spurious |
|
bors try |
tryBuild failed: |
|
bors try |
|
@bevyengine/docs-team This is ready to go but I need another review. |
IceSentry
approved these changes
Apr 4, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
# Objective - `Local`s can no longer be accessed outside of their creating system, but these docs say they can be. - There's also little reason to have a pure wrapper type for `Local`s; they can just use the real type. The parameter name should be sufficiently documenting.
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - `Local`s can no longer be accessed outside of their creating system, but these docs say they can be. - There's also little reason to have a pure wrapper type for `Local`s; they can just use the real type. The parameter name should be sufficiently documenting.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - `Local`s can no longer be accessed outside of their creating system, but these docs say they can be. - There's also little reason to have a pure wrapper type for `Local`s; they can just use the real type. The parameter name should be sufficiently documenting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Locals can no longer be accessed outside of their creating system, but these docs say they can be.Locals; they can just use the real type. The parameter name should be sufficiently documenting.