Skip to content

[Merged by Bors] - Dynamic light clusters #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

[Merged by Bors] - Dynamic light clusters #3968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5009e1d
variable x/y clusters
robtfm Feb 16, 2022
234ba1c
bug fixes
robtfm Feb 16, 2022
a4f5165
support orthographic
robtfm Feb 16, 2022
9b4e34c
cleanup
robtfm Feb 17, 2022
924ef46
remove debugging changes
robtfm Feb 17, 2022
88b84f0
clippy fix
robtfm Feb 17, 2022
1c73e44
clippy fix
robtfm Feb 17, 2022
9fbbfce
improve estimate
robtfm Feb 17, 2022
b142337
improve estimate
robtfm Feb 17, 2022
c1a8cc4
more config options
robtfm Feb 18, 2022
416e258
improve estimate
robtfm Feb 18, 2022
d8f4216
improve estimate
robtfm Feb 18, 2022
fe967ae
optimisations from #3984 + comments
robtfm Feb 19, 2022
7530323
more config options
robtfm Feb 18, 2022
6e2a7e8
Merge branch 'cluster_muck' into dynamic_clusters
robtfm Feb 19, 2022
0d97170
format
robtfm Feb 19, 2022
09fd4d0
bug fixes, improve estimate
robtfm Feb 25, 2022
77a072b
add None config option
robtfm Feb 25, 2022
019d25d
Apply suggestions from code review
robtfm Feb 25, 2022
3782ecb
Apply suggestions from code review
robtfm Feb 25, 2022
47d91c8
Merge branch 'main' into dynamic_clusters
robtfm Mar 4, 2022
6d235bc
format
robtfm Mar 4, 2022
52f0281
Merge branch 'main' into dynamic_clusters
robtfm Mar 5, 2022
d025799
clippy
robtfm Mar 5, 2022
9129857
apply review suggestions
robtfm Mar 5, 2022
14f9ce8
Update crates/bevy_pbr/src/light.rs
robtfm Mar 6, 2022
862efca
skip assignment with screensize 0
robtfm Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions crates/bevy_pbr/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,19 +82,11 @@ impl Plugin for PbrPlugin {
.exclusive_system()
.label(SimulationLightSystems::AddClusters),
)
.add_system_to_stage(
CoreStage::PostUpdate,
// NOTE: Must come after add_clusters!
update_clusters
.label(SimulationLightSystems::UpdateClusters)
.after(TransformSystem::TransformPropagate),
)
.add_system_to_stage(
CoreStage::PostUpdate,
assign_lights_to_clusters
.label(SimulationLightSystems::AssignLightsToClusters)
.after(TransformSystem::TransformPropagate)
.after(SimulationLightSystems::UpdateClusters),
.after(TransformSystem::TransformPropagate),
)
.add_system_to_stage(
CoreStage::PostUpdate,
Expand Down
Loading