Implement Reflect for CameraOutputMode
#21344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beicause
force-pushed
the
reflect-camera-output-mode
branch
from
e4926f0 to
6b7f7c7
Compare
dloukadakis
added
S-Ready-For-Final-Review
dloukadakis
approved these changes
Oct 2, 2025
dloukadakis
added
the
D-Straightforward
james7132
approved these changes
Oct 3, 2025
beicause
added a commit
to beicause/bevy
that referenced
this pull request
Oct 6, 2025
# Objective `CameraOutputMode` doesn't Implement `Reflect` and is ignored in `Camera`. ## Solution Like bevyengine#15355, this Implements opaque `Reflect` for `wgpu::BlendState` thus we can add `#derive(Reflect)` for `CameraOutputMode`. As the commnent says, it can also implement `Reflect` througth `reflect_remote` (bevyengine#6042), but I'm not sure if we should do this for wgpu types. ## Testing ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
CameraOutputModedoesn't ImplementReflectand is ignored inCamera.Solution
Like #15355, this Implements opaque
Reflectforwgpu::BlendStatethus we can add#derive(Reflect)forCameraOutputMode.As the commnent says, it can also implement
Reflectthrougthreflect_remote(#6042), but I'm not sure if we should do this for wgpu types.Testing
ci