Improve many_sprites example (#2075) #2078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
May 2, 2021
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Much improved! Thanks for the contribution :)
alice-i-cecile
added
C-Code-Quality
Member
|
Closes #2075. |
alice-i-cecile
approved these changes
May 3, 2021
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
A solid improvement to code quality. @Byteron, would you be able to comment on whether the new camera movement will still stress-test the frustum culling system appropriately?
mockersf
added
the
S-Pre-Relicense
Member
Author
|
@alice-i-cecile No problem. Pick the one which fits best. I left a comment on #2373. |
alice-i-cecile
removed
the
S-Pre-Relicense
Member
|
Closing in favor of #2785 <3 Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. The the camera movement is different now but I guess it's easier to understand. If that's a problem, I can work on the camera movement system a little more.