Add TypeIdMapExt trait to make TypeIdMap operations more ergonomic #19683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherphil
added
D-Trivial
Shatur
suggested changes
Jun 16, 2025
| @@ -38,6 +38,78 @@ impl<K: Hash + Eq + PartialEq + Clone, V> PreHashMapExt<K, V> for PreHashMap<K, | |||
| /// Iteration order only depends on the order of insertions and deletions. | |||
| pub type TypeIdMap<V> = HashMap<TypeId, V, NoOpHash>; | |||
|
|
|||
| /// Extension trait to make use of [`TypeIdMap`] more ergonomic. | |||
| /// | |||
| /// # Examples | |||
There was a problem hiding this comment.
I think this example is a bit too explicit 🤔 I would probably remove it, all methods are extremely simple.
There was a problem hiding this comment.
I think it’s worth having a simple example of what this is doing, but maybe mot one that uses all of the new functions - I’ll cut this down after adding entry and entry_mut.
| /// map.remove_type::<MyType>(); | ||
| /// assert_eq!(map.len(), 0); | ||
| /// ``` | ||
| pub trait TypeIdMapExt<V> { |
There was a problem hiding this comment.
Maybe add entry/entry_mut as well?
theotherphil
added
S-Waiting-on-Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #19642 by enabling e.g.
in place of
Solution
Add an extension trait
TypeIdMapExtwithinsert_type,get_type,get_type_mutandremove_typecounterparts forinsert,get,get_mutandremove.Testing
Doc test.