Fix sparse set components ignoring insert_if_new
/InsertMode
#19059
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I've been tinkering with ECS insertion/removal lately, and noticed that sparse sets just... don't interact with
InsertMode
at all. Sure enough, usinginsert_if_new
with a sparse component does the same thing asinsert
.Solution
BundleInfo::write_components
to drop the new value if the entity already has the component andInsertMode
isKeep
.Testing
Minimal reproduction:
Code
Here it is on Bevy Playground (0.15.3):
https://learnbevy.com/playground?share=2a96a68a81e804d3fdd644a833c1d51f7fa8dd33fc6192fbfd077b082a6b1a41
Output on
main
:Output with this PR :