Skip to content

Distinguish .target() and .target in Trigger<Pointer<E>> #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Zeophlite
Copy link
Contributor

Objective

Solution

  • Describe the solution used to achieve the objective above.
  • Added an example that demos picking in a heirachy

Testing

  • Ran cargo build and cargo test --all-targets
  • Ran directional_navigation example

@ickshonpe ickshonpe added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change A-Pointers Relating to Bevy pointer abstractions D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 29, 2025
@chescock
Copy link
Contributor

I think #18710 is trying to tackle this same confusion, while also making the "original target" available for all events instead of just Pointer events. It's also proposing a different naming convention of target vs current_target. I don't know what the right answer is here, but it might help to combine the discussions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events A-Pointers Relating to Bevy pointer abstractions C-Code-Quality A section of code that is hard to understand or change D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target::target and Target::target() return different entities
3 participants