Add test for invalid skinned meshes #18763
Open
+241
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add a test that would have caught #16929 and #18712.
Solution
The PR adds a
test_invalid_skinned_mesh
example that creates various valid and invalid skinned meshes. This is designed to catch panics via CI, and can be inspected visually. It also tests skinned meshes + motion blur.The screenshot shows all the tests, but two are currently disabled as they cause panics. #18074 will re-enable them.
Concerns
test
in the name so it's not confused with a real example.Testing
Tested on Win10/Nvidia, across Vulkan, WebGL/Chrome, WebGPU/Chrome.