deprecate SimpleExecutor
#18753
Merged
deprecate SimpleExecutor
#18753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElliottjPierce
added
D-Trivial
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
mostly copied from previous pr
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
added
D-Straightforward
| So what was `SimpleExecutor` good at? Not much. That's why we plan to remove it. Removing it will reduce some maintenance and consistency burdons on maintainers, allowing them to focus on more exciting features! | ||
|
|
||
| If you were using `SimpleExecutor`, consider upgrading to `SingleThreadedExecutor` instead, or try `MultiThreadedExecutor` if if fits the schedule. | ||
| It's worth mentioning that `SimpleExecutor` runs deferred commands inbetween *each* system, regardless of it it was needed. |
There was a problem hiding this comment.
This needs to come earlier, and talk more about the UX side of things.
There was a problem hiding this comment.
Good call. Clearly justifying this to users is important. It's a lot better now I think. Thanks!
alice-i-cecile
added
the
X-Contentious
Co-Authored-By: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
…/ElliottjPierce/bevy into deprecate-simple-system-executor
sirius94
reviewed
Apr 8, 2025
alice-i-cecile
approved these changes
Apr 8, 2025
chescock
approved these changes
Apr 16, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
NthTensor
approved these changes
Apr 26, 2025
alice-i-cecile
added
S-Needs-SME
andrewzhurov
pushed a commit
to andrewzhurov/bevy
that referenced
this pull request
May 17, 2025
# Objective Contributes to bevyengine#18741 and bevyengine#18453. ## Solution Deprecate `SimpleExecutor`. If users run into migration issues, we can backtrack. Otherwise, we follow this up with bevyengine#18741 We can't easily deprecate the module too because of [this](rust-lang/rust#47238). ## Testing CI --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Cyrill Schenkel <cyrill.schenkel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Contributes to #18741 and #18453.
Solution
Deprecate
SimpleExecutor. If users run into migration issues, we can backtrack. Otherwise, we follow this up with #18741We can't easily deprecate the module too because of this.
Testing
CI