Skip to content

Implement RelationshipSourceCollection for BTreeSet #18469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2025
Merged

Implement RelationshipSourceCollection for BTreeSet #18469

merged 4 commits into from
May 4, 2025

Conversation

Brezak
Copy link
Contributor

@Brezak Brezak commented Mar 21, 2025

Objective

BTreeSet doesn't implement RelationshipSourceCollection.

Solution

Implement it.

Testing

cargo clippy

Showcase

You can now use BTreeSet in a RelationshipTarget

@Brezak Brezak force-pushed the relationship-collection-btreeset branch from 4425d71 to fd67b8b Compare March 21, 2025 20:58
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 23, 2025
chescock
chescock approved these changes Mar 24, 2025
View reviewed changes
@JaySpruce JaySpruce added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 28, 2025
@Brezak Brezak force-pushed the relationship-collection-btreeset branch from a9ad2f6 to b6fab3c Compare April 5, 2025 12:12
@mockersf mockersf enabled auto-merge May 4, 2025 08:58
@mockersf mockersf added this pull request to the merge queue May 4, 2025
Merged via the queue into bevyengine:main with commit c6d41a0 May 4, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chescock chescock chescock approved these changes

@mockersf mockersf mockersf approved these changes

@JaySpruce JaySpruce JaySpruce approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Brezak @chescock @mockersf @JaySpruce @alice-i-cecile