Skip to content

Compile fail stderr #18072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Compile fail stderr #18072

wants to merge 3 commits into from
+1,177 −430

Conversation

Brezak
Copy link
Contributor

@Brezak Brezak commented Feb 27, 2025

Objective

CI compile fail tests currently don't check stderr output. See #18056 (comment)

Supercedes #18056

Solution

  • Update compile_fail_utils to use the newest ui_test
  • Borrow some regexes from miri.
  • Enable checking and bless compile fail .stderr files.

Testing

Ran the updated tests.
I suggest you check some of the changed .stderr files. Look for any private filesystem information in paths.

@Brezak Brezak force-pushed the compile-fail-stderr branch 3 times, most recently from 51a6d03 to 30a3ce8 Compare February 27, 2025 20:28
@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 27, 2025
@Brezak Brezak force-pushed the compile-fail-stderr branch 2 times, most recently from f5ec018 to 258d3e3 Compare March 1, 2025 10:52
@Brezak Brezak force-pushed the compile-fail-stderr branch from 258d3e3 to d20b5f7 Compare March 1, 2025 11:02
@Brezak Brezak force-pushed the compile-fail-stderr branch 8 times, most recently from a84a777 to 13ccaa9 Compare March 1, 2025 16:09
@Brezak Brezak force-pushed the compile-fail-stderr branch from 13ccaa9 to 026a714 Compare March 1, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brezak @alice-i-cecile