Load each glTF skin at most once. #18026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we reload a glTF skin each time we encounter a node that references it. By checking for duplicates, PR bevyengine#18013 turned this into a fatal error. But this was always wasteful. This commit fixes the issue by caching each skin by its index as we load it. The Maya babylon.js export plugin likes to emit glTFs with multiple nodes that reference the same skin, so this effectively unbreaks Maya rigs.
pcwalton
requested review from
andriyDev,
BenjaminBrienen and
alice-i-cecile
pcwalton
added
A-glTF
andriyDev
approved these changes
Feb 25, 2025
| @@ -801,7 +801,7 @@ async fn load_gltf<'a, 'b, 'c>( | |||
|
|
|||
| let mut nodes = HashMap::<usize, Handle<GltfNode>>::default(); | |||
| let mut named_nodes = <HashMap<_, _>>::default(); | |||
| let mut skins = vec![]; | |||
| let mut skins = <HashMap<_, _>>::default(); | |||
There was a problem hiding this comment.
This syntax is crazy. We can't just do HashMap::default() here?
alice-i-cecile
approved these changes
Feb 25, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we reload a glTF skin each time we encounter a node that references it. By checking for duplicates, PR #18013 turned this into a fatal error. But this was always wasteful. This commit fixes the issue by caching each skin by its index as we load it.
The Maya babylon.js export plugin likes to emit glTFs with multiple nodes that reference the same skin, so this effectively unbreaks Maya rigs.