Fix mesh tangent attribute matching in mesh transform operations #17992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloucks
force-pushed
the
issue-17170-mesh-transform-tangents
branch
from
f49ae62 to
2bd4cac
Compare
alice-i-cecile
added
C-Bug
aloucks
force-pushed
the
issue-17170-mesh-transform-tangents
branch
3 times, most recently
from
7545db6 to
c324540
Compare
aloucks
force-pushed
the
issue-17170-mesh-transform-tangents
branch
from
c324540 to
fecdcb3
Compare
greeble-dev
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
I've added a test and confirmed this PR fixes the issue. Before and after below. I'll submit the test as a separate PR, although I wouldn't object if it got rolled into this PR.
| self.attribute_mut(Mesh::ATTRIBUTE_TANGENT) | ||
| { | ||
| // Transform tangents | ||
| tangents.iter_mut().for_each(|tangent| { | ||
| *tangent = (rotation * Vec3::from_slice(tangent).normalize_or_zero()).to_array(); | ||
| let handedness = tangent[3]; | ||
| *tangent = (rotation * Vec3::from_slice(tangent).normalize_or_zero()) |
There was a problem hiding this comment.
I think this normalize is redundant? Although it's consistent with the normal calculation, so probably not worth changing either way. Flagging up just for a second opinion.
superdump
approved these changes
Mar 7, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17170
Objective
Tangents are not currently transformed as described in #17170. I came across this while working on #17989 and it seemed like low hanging fruit.