GhostNode trait
#17901
Open
GhostNode trait
#17901
+239
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give every entity in the UI hierarchy a `UiElement` marker component and, if the "ghost_nodes" feature is enabled, implement the `Ghost` trait for `UiElement`
* `Ghost` to `GhostNode` * `UiElement` to `UiNode` * `Ghost::Completion` to `GhostNode::Actual` Both system param impl changes: * `iter_ui_children` to `iter_actual_actual_children` * `is_ui_node` to `is_actual_node` The `experimental` module now only contains the `GhostNode` trait and it's implementation. It works with any hierarchy now, not just UI nodes. The "ghost_nodes" feature gate and UI specfic navigation implementation has been moved to a new `navigation` module.
…nto ghostnode-trait
ickshonpe
added
A-UI
|
Triage: has merge conflicts |
janhohenheim
added
the
S-Waiting-on-Author
ickshonpe
added
S-Blocked
I can't even remember writing these ghost node PRs. I think updating them is pointless right now, need to get the computed node and UI transform changes merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Replace the UI's ghost node implementation with a trait that can be used with any hierarchy, not just UI
Nodes.Solution
Make
GhostNodeinto a trait with anActualassociated type.GhostNodeshould be implemented on a marker component that must be inserted on every entity in the collapsible hierarchy.The flattened view of the hierarchy sees only those nodes with an
Actualcomponent.The UI specfic parts of the old ghost nodes implementation and the feature gate have been moved to a new module named
navigation.The marker component that implements
GhostNodeis calledUiNodeand the associatedActualtype isNode.NoderequiresUiNode.The navigation
SystemParams are mostly unchanged except for some renamings:iter_ui_children->iter_actual_childrenis_ui_node->is_actualMigration Guide