[Merged by Bors] - Error message improvements for shader compilation/gltf loading #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Mar 29, 2021
MinerSebas
reviewed
Mar 29, 2021
|
CI failures seem to be unrelated, they happen in #1784 as well |
Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
jakobhellermann
force-pushed
the
shader-quality-of-life
branch
from
cac1101 to
2ca43ac
Compare
mockersf
approved these changes
Apr 11, 2021
alice-i-cecile
approved these changes
Apr 11, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Nice! This was one of those minor annoyances where thought "I should fix this" every time I saw it, but never bothered to do it. Thanks! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
- prints glsl compile error message in multiple lines instead of `thread 'main' panicked at 'called Result::unwrap() on an Err value: Compilation("glslang_shader_parse:\nInfo log:\nERROR: 0:335: \'assign\' : l-value required \"anon@7\" (can\'t modify a uniform)\nERROR: 0:335: \'\' : compilation terminated \nERROR: 2 compilation errors. No code generated.\n\n\nDebug log:\n\n")', crates/bevy_render/src/pipeline/pipeline_compiler.rs:161:22`
- makes gltf error messages have more context
New error:
```rust
thread 'Compute Task Pool (5)' panicked at 'Shader compilation error:
glslang_shader_parse:
Info log:
ERROR: 0:12: 'assign' : l-value required "anon@1" (can't modify a uniform)
ERROR: 0:12: '' : compilation terminated
ERROR: 2 compilation errors. No code generated.
', crates/bevy_render/src/pipeline/pipeline_compiler.rs:364:5
```
These changes are a bit unrelated. I can open separate PRs if someone wants that.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
jihiggins
pushed a commit
to jihiggins/bevy
that referenced
this pull request
Apr 18, 2021
…ngine#1786) - prints glsl compile error message in multiple lines instead of `thread 'main' panicked at 'called Result::unwrap() on an Err value: Compilation("glslang_shader_parse:\nInfo log:\nERROR: 0:335: \'assign\' : l-value required \"anon@7\" (can\'t modify a uniform)\nERROR: 0:335: \'\' : compilation terminated \nERROR: 2 compilation errors. No code generated.\n\n\nDebug log:\n\n")', crates/bevy_render/src/pipeline/pipeline_compiler.rs:161:22` - makes gltf error messages have more context New error: ```rust thread 'Compute Task Pool (5)' panicked at 'Shader compilation error: glslang_shader_parse: Info log: ERROR: 0:12: 'assign' : l-value required "anon@1" (can't modify a uniform) ERROR: 0:12: '' : compilation terminated ERROR: 2 compilation errors. No code generated. ', crates/bevy_render/src/pipeline/pipeline_compiler.rs:364:5 ``` These changes are a bit unrelated. I can open separate PRs if someone wants that.
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
…ngine#1786) - prints glsl compile error message in multiple lines instead of `thread 'main' panicked at 'called Result::unwrap() on an Err value: Compilation("glslang_shader_parse:\nInfo log:\nERROR: 0:335: \'assign\' : l-value required \"anon@7\" (can\'t modify a uniform)\nERROR: 0:335: \'\' : compilation terminated \nERROR: 2 compilation errors. No code generated.\n\n\nDebug log:\n\n")', crates/bevy_render/src/pipeline/pipeline_compiler.rs:161:22` - makes gltf error messages have more context New error: ```rust thread 'Compute Task Pool (5)' panicked at 'Shader compilation error: glslang_shader_parse: Info log: ERROR: 0:12: 'assign' : l-value required "anon@1" (can't modify a uniform) ERROR: 0:12: '' : compilation terminated ERROR: 2 compilation errors. No code generated. ', crates/bevy_render/src/pipeline/pipeline_compiler.rs:364:5 ``` These changes are a bit unrelated. I can open separate PRs if someone wants that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread 'main' panicked at 'called Result::unwrap() on an Err value: Compilation("glslang_shader_parse:\nInfo log:\nERROR: 0:335: \'assign\' : l-value required \"anon@7\" (can\'t modify a uniform)\nERROR: 0:335: \'\' : compilation terminated \nERROR: 2 compilation errors. No code generated.\n\n\nDebug log:\n\n")', crates/bevy_render/src/pipeline/pipeline_compiler.rs:161:22New error:
These changes are a bit unrelated. I can open separate PRs if someone wants that.