Skip to content

Conversation

@PPakalns
Copy link
Contributor

@PPakalns PPakalns commented Feb 7, 2025

Objective

Solution

Using functionality added in #9172

Testing

  • Tested in personal project where multiple cameras are rendered with objects rendered in transparent 2d pass.

@PPakalns PPakalns force-pushed the parallelize-transparent-pass-node-upstream branch from a385fa0 to fc006c5 Compare February 7, 2025 23:55
@PPakalns
Copy link
Contributor Author

PPakalns commented Feb 7, 2025

Added small fix, postpone diagnostics retrieval until last moment.

Ready for review.

Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do it for the opaque pass as well?

@IceSentry
Copy link
Contributor

Nvm, it's already done there

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Feb 8, 2025
@superdump superdump added this pull request to the merge queue Feb 9, 2025
Merged via the queue into bevyengine:main with commit 2d62026 Feb 9, 2025
28 checks passed
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 17, 2025
…bevyengine#17735)

# Objective

- Add command encoding parallelization to transparent 2d pass render
node.
- Improves bevyengine#17733

## Solution

Using functionality added in
bevyengine#9172

## Testing

- Tested in personal project where multiple cameras are rendered with
objects rendered in transparent 2d pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants