Missing UI glpyhs fix #17729
Merged
Missing UI glpyhs fix #17729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rparrett
approved these changes
Feb 7, 2025
alice-i-cecile
approved these changes
Feb 7, 2025
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 17, 2025
# Objective Fixes bevyengine#17718 ## Solution Schedule `text_system` before `AssetEvents`. I guess what was happening here is that glyphs weren't shown because `text_system` was running before `AssetEevents` and so `prepare_uinodes` never recieves the the asset modified event about the glyph texture atlas image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #17718
Solution
Schedule
text_systembeforeAssetEvents.I guess what was happening here is that glyphs weren't shown because
text_systemwas running beforeAssetEeventsand soprepare_uinodesnever recieves the the asset modified event about the glyph texture atlas image.