Upgrade to wgpu v24 #17542

JMS55 · 2025-01-26T09:22:01Z

Didn't remove WgpuWrapper. Not sure if it's needed or not still.

Testing

Did you test these changes? If so, how? Example runner
Are there any parts that need more testing? Web (portable atomics thingy?), DXC.

Migration Guide

Bevy has upgraded to wgpu v24.
When using the DirectX 12 rendering backend, the new priority system for choosing a shader compiler is as follows:
- If the WGPU_DX12_COMPILER environment variable is set at runtime, it is used
- Else if the new statically-linked-dxc feature is enabled, a custom version of DXC will be statically linked into your app at compile time.
- Else Bevy will look in the app's working directory for dxcompiler.dll and dxil.dll at runtime.
- Else if they are missing, Bevy will fall back to FXC (not recommended)

github-actions · 2025-01-30T04:11:45Z

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

JMS55 · 2025-01-30T06:52:03Z

I've changed how wgpu works with DX12 so that it no longer uses FXC.

If wgpu ever defaults to DX12 (I think I've seen people have that happen, despite the fact that I thought VK was supposed to be the default) then it's going to try and use a dynamic DXC and crash since it'll be missing. Users can enable the static DXC feature to fix that, or switch to VK, but it might be a little confusing.

Eventually once wgpu's DX12 backend is more stable we should consider making static-dxc on by default, and removing vulkan (and OpenGL) by default for smaller binary sizes.

alice-i-cecile · 2025-01-30T23:27:41Z

Kicking off an example run: TheBevyFlock/bevy-example-runner#108

IceSentry

Assuming the example runner passes LGTM

JMS55 · 2025-01-31T02:04:43Z

@alice-i-cecile good to merge?

rparrett · 2025-02-05T16:06:44Z

The webgpu failures from the example runner reproduce for me locally (chrome 133, mac/m4 and win11/4080) with the 3d_scene example. (main is ok, webgl2 is ok)

cargo run -p build-wasm-example -- --api webgpu 3d_scene && basic-http-server examples/wasm/

Expand a lot of errors

The number of storage textures (12) in the Compute stage exceeds the maximum per-stage limit (8).
 - While validating binding counts
 - While validating [BindGroupLayoutDescriptor ""downsample depth bind group layout""]
 - While calling [Device].CreateBindGroupLayout([BindGroupLayoutDescriptor ""downsample depth bind group layout""]).
Understand this warningAI
127.0.0.1/:1 The number of storage textures (12) in the Compute stage exceeds the maximum per-stage limit (8).
 - While validating binding counts
 - While validating [BindGroupLayoutDescriptor ""downsample multisample depth bind group layout""]
 - While calling [Device].CreateBindGroupLayout([BindGroupLayoutDescriptor ""downsample multisample depth bind group layout""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:34:1 error: use of variable address space 'push_constant' requires enabling extension 'chromium_experimental_push_constant'
var<push_constant> constants: Constants;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid BindGroupLayout "downsample depth bind group layout"] is invalid.
 - While calling [Device].CreatePipelineLayout([PipelineLayoutDescriptor]).
Understand this warningAI
127.0.0.1/:1 [Invalid PipelineLayout (unlabeled)] is invalid.
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""downsample depth first phase pipeline""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:39:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:27:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,
    ^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""main occlusion culling build non-indexed indirect parameters""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:39:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:27:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,
    ^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""frustum culling build non-indexed indirect parameters""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:222:1 error: use of variable address space 'push_constant' requires enabling extension 'chromium_experimental_push_constant'
var<push_constant> push_constants: PushConstants;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""mesh preprocessing (early GPU occlusion culling)""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:40:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:28:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,
    ^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""main occlusion culling build indexed indirect parameters""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:39:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:27:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,
    ^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""early occlusion culling build non-indexed indirect parameters""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:34:1 error: use of variable address space 'push_constant' requires enabling extension 'chromium_experimental_push_constant'
var<push_constant> constants: Constants;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid BindGroupLayout "downsample multisample depth bind group layout"] is invalid.
 - While calling [Device].CreatePipelineLayout([PipelineLayoutDescriptor]).
Understand this warningAI
127.0.0.1/:1 [Invalid PipelineLayout (unlabeled)] is invalid.
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""downsample depth multisample first phase pipeline""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:40:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:28:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,
    ^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""early occlusion culling build indexed indirect parameters""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:40:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:28:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,
    ^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""frustum culling build indexed indirect parameters""]).
Understand this warningAI
127.0.0.1/:1 [Invalid PipelineLayout (unlabeled)] is invalid.
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""downsample depth second phase pipeline""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:39:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:27:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,
    ^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""late occlusion culling build non-indexed indirect parameters""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:220:1 error: use of variable address space 'push_constant' requires enabling extension 'chromium_experimental_push_constant'
var<push_constant> push_constants: PushConstants;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Understand this warningAI
127.0.0.1/:1 [Invalid ShaderModule (unlabeled)] is invalid.
 - While validating compute stage ([Invalid ShaderModule (unlabeled)], entryPoint: "main").
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor ""mesh preprocessing (late GPU occlusion culling)""]).
Understand this warningAI
127.0.0.1/:1 Compilation log for [Invalid ShaderModule (unlabeled)]:
1 error(s) generated while compiling the shader:
:40:1 error: atomic variables in 'storage' address space must have 'read_write' access mode
var<storage> indirect_parameters_metadata: array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

:28:5 note: atomic sub-type of 'array<IndirectParametersMetadataX_naga_oil_mod_XMJSXM6K7OBRHEOR2NVSXG2C7OBZGK4DSN5RWK43TL52HS4DFOMX>' is declared here
    early_instance_count: atomic<u32>,

…es bound

JMS55 · 2025-02-08T19:49:44Z

@pcwalton please review the previous two commits for gpu preprocessing changes.

pcwalton

LGTM!

crates/bevy_render/src/batching/gpu_preprocessing.rs

crates/bevy_render/src/experimental/occlusion_culling/mesh_preprocess_types.wgsl

JMS55 · 2025-02-08T21:06:22Z

The only issue remaining is texture_binding_array fails on macOS on the example runner. Not sure if there's a way to check logs or anything...

The fact that it only fails on macOS is probably a wgpu bug though. I'd like to merge this PR, we can look into it later.

ChristopherBiscardi · 2025-02-08T21:49:38Z

on m1 mac

2025-02-08T21:47:30.165803Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "macOS 14.2.1 Sonoma", kernel: "23.2.0", cpu: "Apple M1 Max", core_count: "10", memory: "64.0 GiB" }
2025-02-08T21:47:30.260362Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }

texture_binding_array

pcss

ssr

❯ cargo run --example ssr
   Compiling bevy v0.16.0-dev (/Users/chris/github/bevyengine/bevy)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.93s
     Running `target/debug/examples/ssr`
2025-02-08T21:48:00.292415Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "macOS 14.2.1 Sonoma", kernel: "23.2.0", cpu: "Apple M1 Max", core_count: "10", memory: "64.0 GiB" }
2025-02-08T21:48:00.386114Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
2025-02-08T21:48:01.014102Z  INFO bevy_winit::system: Creating new window Bevy Screen Space Reflections Example (0v1)
2025-02-08T21:48:06.615888Z ERROR wgpu::backend::wgpu_core: Shader translation error for stage ShaderStages(FRAGMENT): mapping of ResourceBinding { group: 0, binding: 17 } is missing
2025-02-08T21:48:06.615916Z ERROR wgpu::backend::wgpu_core: Please report it to https://github.com/gfx-rs/wgpu
2025-02-08T21:48:06.615937Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default
thread 'Compute Task Pool (2)' panicked at /Users/chris/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-24.0.1/src/backend/wgpu_core.rs:1303:26:
wgpu error: Validation Error

Caused by:
  In Device::create_render_pipeline, label = 'deferred_lighting_pipeline'
    Internal error in ShaderStages(FRAGMENT) shader: mapping of ResourceBinding { group: 0, binding: 17 } is missing


note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `bevy_render::render_resource::pipeline_cache::PipelineCache::process_pipeline_queue_system`!
thread '<unnamed>' panicked at /Users/chris/github/bevyengine/bevy/crates/bevy_render/src/render_resource/pipeline_cache.rs:577:28:
index out of bounds: the len is 0 but the index is 14
Encountered a panic in system `bevy_render::renderer::render_system`!

ickshonpe

Doesn't break anything with UI or text rendering, I don't know anything about anything else at all.

JMS55 · 2025-02-08T22:04:16Z

2025-02-08T21:48:06.615888Z ERROR wgpu::backend::wgpu_core: Shader translation error for stage ShaderStages(FRAGMENT): mapping of ResourceBinding { group: 0, binding: 17 } is missing
2025-02-08T21:48:06.615916Z ERROR wgpu::backend::wgpu_core: Please report it to https://github.com/gfx-rs/wgpu
2025-02-08T21:48:06.615937Z ERROR wgpu::backend::wgpu_core: Handling wgpu errors as fatal by default

Seems like a wgpu bug

superdump · 2025-02-09T06:09:55Z

CI broke on this in the windows dx12 example runner:

2025-02-08T23:12:40.192270Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Windows Server 2022 Datacenter", kernel: "20348", cpu: "AMD EPYC 7763 64-Core Processor", core_count: "2", memory: "16.0 GiB" }    

thread 'main' panicked at crates\bevy_render\src\renderer\mod.rs:197:10:
Unable to find a GPU! Make sure you have installed required drivers!
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\examples\ambiguity_detection.exe` (exit code: 101)

mockersf · 2025-02-09T18:18:00Z

JMS55#32 should fix windows dx12 CI

restore fallback behaviour for dx12 compiler

JMS55 added 6 commits January 26, 2025 01:19

Upgrade to wgpu v24

8aead56

Fixes

ed8c29a

Fixes

886cfa3

Fmt

3e96e0f

Fmt

919b12f

Fix headless render example

42e7965

github-actions bot mentioned this pull request Jan 26, 2025

17542 TheBevyFlock/bevy-example-runner#96

Closed

alice-i-cecile added this to the 0.16 milestone Jan 26, 2025

alice-i-cecile added A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on X-Uncontroversial This work is generally agreed upon S-Needs-Testing Testing must be done before this is safe to merge labels Jan 26, 2025

JMS55 requested a review from atlv24 January 27, 2025 05:39

atlv24 approved these changes Jan 28, 2025

View reviewed changes

Use static linking for DXC

1f226ef

JMS55 added the M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jan 30, 2025

Merge commit '909b02e9de418fcf3b8960e98c3de423505eadd5' into wgpu24

8e24262

JMS55 marked this pull request as ready for review January 30, 2025 04:27

Elabajaba approved these changes Jan 30, 2025

View reviewed changes

JMS55 requested review from alice-i-cecile and IceSentry January 30, 2025 05:41

alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Testing Testing must be done before this is safe to merge labels Jan 30, 2025

github-actions bot mentioned this pull request Jan 30, 2025

17542 TheBevyFlock/bevy-example-runner#108

Closed

IceSentry approved these changes Jan 31, 2025

View reviewed changes

mosure approved these changes Feb 1, 2025

View reviewed changes

alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Testing Testing must be done before this is safe to merge labels Feb 5, 2025

JMS55 added 4 commits February 8, 2025 10:55

Merge commit 'f3d8eb89560e709653f3b2ac932558d30014f8c7' into wgpu24

844a431

Meshlet refactor tweaks

4f9f031

Fix IndirectParametersMetadata handling

d6f9724

Gate gpu culling behind push constant feature and >=12 storage textur…

adb6c6f

…es bound

github-actions bot mentioned this pull request Feb 8, 2025

17542 TheBevyFlock/bevy-example-runner#113

Closed

pcwalton approved these changes Feb 8, 2025

View reviewed changes

crates/bevy_render/src/batching/gpu_preprocessing.rs Show resolved Hide resolved

crates/bevy_render/src/experimental/occlusion_culling/mesh_preprocess_types.wgsl Show resolved Hide resolved

Add comment about 12 textures

083f28c

JMS55 removed the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label Feb 8, 2025

Merge commit '7fc122ad16418a0392118fb361a51d92148002c2' into wgpu24

09124fb

ickshonpe approved these changes Feb 8, 2025

View reviewed changes

superdump added this pull request to the merge queue Feb 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2025

JMS55 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 8, 2025

restore fallback behavior for dx12 compiler

76d3a70

JMS55 added 2 commits February 9, 2025 11:19

Merge pull request #32 from mockersf/fix-windows-ci

53f1617

restore fallback behaviour for dx12 compiler

Merge commit '0b11b1f37eb987ab869ef0f68b84ba85a1707ea7' into wgpu24

24dbef9

alice-i-cecile enabled auto-merge February 9, 2025 19:28

alice-i-cecile added this pull request to the merge queue Feb 9, 2025

Merged via the queue into bevyengine:main with commit 669d139 Feb 9, 2025
32 checks passed

alice-i-cecile mentioned this pull request Feb 10, 2025

iOS app panics on will_terminate #16637

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to wgpu v24 #17542

Upgrade to wgpu v24 #17542

JMS55 commented Jan 26, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025

JMS55 commented Jan 30, 2025

alice-i-cecile commented Jan 30, 2025

IceSentry left a comment

JMS55 commented Jan 31, 2025

rparrett commented Feb 5, 2025 •

edited

Loading

JMS55 commented Feb 8, 2025

pcwalton left a comment

JMS55 commented Feb 8, 2025 •

edited

Loading

ChristopherBiscardi commented Feb 8, 2025

ickshonpe left a comment •

edited

Loading

JMS55 commented Feb 8, 2025 •

edited

Loading

superdump commented Feb 9, 2025 •

edited

Loading

mockersf commented Feb 9, 2025

Upgrade to wgpu v24 #17542

Upgrade to wgpu v24 #17542

Conversation

JMS55 commented Jan 26, 2025 • edited Loading

Testing

Migration Guide

github-actions bot commented Jan 30, 2025

JMS55 commented Jan 30, 2025

alice-i-cecile commented Jan 30, 2025

IceSentry left a comment

Choose a reason for hiding this comment

JMS55 commented Jan 31, 2025

rparrett commented Feb 5, 2025 • edited Loading

JMS55 commented Feb 8, 2025

pcwalton left a comment

Choose a reason for hiding this comment

JMS55 commented Feb 8, 2025 • edited Loading

ChristopherBiscardi commented Feb 8, 2025

texture_binding_array

pcss

ssr

ickshonpe left a comment • edited Loading

Choose a reason for hiding this comment

JMS55 commented Feb 8, 2025 • edited Loading

superdump commented Feb 9, 2025 • edited Loading

mockersf commented Feb 9, 2025

JMS55 commented Jan 26, 2025 •

edited

Loading

rparrett commented Feb 5, 2025 •

edited

Loading

JMS55 commented Feb 8, 2025 •

edited

Loading

ickshonpe left a comment •

edited

Loading

JMS55 commented Feb 8, 2025 •

edited

Loading

superdump commented Feb 9, 2025 •

edited

Loading