Move #![warn(clippy::allow_attributes, clippy::allow_attributes_without_reason)] to the workspace Cargo.toml
#17374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out_reason)]` to the workspace `Cargo.toml`
…thout_reason)]` to bevy_mikktspace
BenjaminBrienen
added
D-Trivial
BenjaminBrienen
suggested changes
Jan 14, 2025
benches/benches/bevy_ecs/components/add_remove_very_big_table.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Brienen <benjamin.brienen@outlook.com>
Contributor
Author
|
This PR will be removed from draft mode after CI completes successfully. |
BenjaminBrienen
approved these changes
Jan 14, 2025
2 tasks
BenjaminBrienen
removed
D-Trivial
BenjaminBrienen
added
D-Straightforward
alice-i-cecile
approved these changes
Jan 15, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
…out_reason)]` to the workspace `Cargo.toml` (bevyengine#17374) # Objective Fixes bevyengine#17111 ## Solution Move `#![warn(clippy::allow_attributes, clippy::allow_attributes_without_reason)]` to the workspace `Cargo.toml` ## Testing Lots of CI testing, and local testing too. --------- Co-authored-by: Benjamin Brienen <benjamin.brienen@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #17111
Solution
Move
#![warn(clippy::allow_attributes, clippy::allow_attributes_without_reason)]to the workspaceCargo.tomlTesting
Lots of CI testing, and local testing too.