Skip to content

Add the original source for Oklab conversions #17199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add the original source for Oklab conversions #17199

merged 1 commit into from
Jan 7, 2025

Conversation

eero-lehtinen
Copy link
Contributor

@eero-lehtinen eero-lehtinen commented Jan 6, 2025 •
edited
Loading

Objective

  • Add the original source for Oklab calculations (a blog from the creator of Oklab) instead of linking to other Rust crates.

Solution

  • Update the links.

@eero-lehtinen eero-lehtinen changed the title Add original source for Oklab conversions Add the original source for Oklab conversions Jan 6, 2025
LikeLakers2
LikeLakers2 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@LikeLakers2 LikeLakers2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, meant to add a comment to my approval: Thanks for catching the weird wording I put there when I originally truncated the float literals. :D

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Color Color spaces and color math S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 7, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 7, 2025
Merged via the queue into bevyengine:main with commit 7cd1cba Jan 7, 2025
32 checks passed
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@eero-lehtinen @mrchantey
Add the original source for Oklab conversions (bevyengine#17199)
19cc3ee 
# Objective

- Add the original source for Oklab calculations (a blog from the
creator of Oklab) instead of linking to other Rust crates.

## Solution

- Update the links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LikeLakers2 LikeLakers2 LikeLakers2 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Color Color spaces and color math C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eero-lehtinen @LikeLakers2 @alice-i-cecile